[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Alexey Namyotkin added the comment: Thanks, Terry. I signed it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Terry J. Reedy added the comment: Alexey, to repeat what I said to Thomas above: please sign a contributor agreement for your patches to be considered. https://www.python.org/psf/contrib/ https://www.python.org/psf/contrib/contrib-form/ -- ___ Pyth

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Change by Terry J. Reedy : -- versions: +Python 3.11 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Change by Alexey Namyotkin : -- pull_requests: +24786 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/26152 ___ Python tracker ___ _

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Change by Alexey : -- nosy: +Namyotkin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Martin Panter added the comment: 1) The real problem is when _tunnel() internally calls getresponse(), it notices the connection cannot be reused for another request, and closes the socket object. Perhaps I should rethink my logic; maybe move sock and detach() to HTTPResponse. 2) With some ro

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Thomas Belhalfaoui added the comment: Martin, I went through your patch and made some simple tests, and I have a couple of questions. 1) When I run the following code, I get a "Bad file descriptor" : conn = httplib.HTTPConnection("uk.proxymesh.com", 31280) conn.set_tunnel("www.google.com", 80)

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Thomas Belhalfaoui added the comment: Terry: Thanks for the form, I just filled it. Martin: Thanks for sending your patch. I will dive into it, and try to figure out how to add support for passing in the tunnel details to the HTTPSConnection constructor. -- __

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Martin Panter added the comment: This is the patch I had in mind. It looks like it only implements the detach() method, so we would still need to add support for passing in the tunnel details to the HTTPSConnection constructor. This patch would allow doing stuff at a lower level than the exist

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Changes by Martin Panter : -- stage: test needed -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Terry J. Reedy added the comment: Thomas, please sign a contributor agreement for your patches to be considered. https://www.python.org/psf/contrib/ https://www.python.org/psf/contrib/contrib-form/ -- nosy: +terry.reedy stage: -> test needed ___ Pyth

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Thomas added the comment: Martin: Thanks for your quick answer (and sorry for sending the whole file) ! I think it is indeed a good idea to detach the proxy connection and treat it as any other connection, as you did in your patch. It would be great if you would be able to dig it up !

[issue24964] Add tunnel CONNECT response headers to httplib / http.client

Martin Panter added the comment: Such a change would involve adding a new API, so should go into a new version of Python. Thomas: a diff rather than a full copy of the changed file would be more convenient. Also, if this gets accepted, test cases and documentation would be needed. It is also