[issue24939] Remove unicode_format.h from stringlib

anthony shaw added the comment: The code is mostly: FieldNameIterator * related functions FormatterIterator * related functions MarkupIterator * related functions There are a few other utility methods in there as well -- ___ Python tracker

[issue24939] Remove unicode_format.h from stringlib

Eric V. Smith added the comment: I think I meant things like PyFieldNameIter_Type, but it would require some analysis. -- versions: +Python 3.8 -Python 3.6 ___ Python tracker ___

[issue24939] Remove unicode_format.h from stringlib

anthony shaw added the comment: > The things that are in this file but are unrelated to unicodeobject.c are the support routines for implementing string.Formatter. I'm not sure which functions that relates to, if you could let me know I'd be happy to add those to the PR. -- __

[issue24939] Remove unicode_format.h from stringlib

Change by anthony shaw : -- keywords: +patch pull_requests: +13050 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue24939] Remove unicode_format.h from stringlib

anthony shaw added the comment: Eric, there have been further changes to Objects/stringlib/unicode_format.h since this original note, I've raised a PR with the intent of your note from 2015. There also hasn't been any change to the situation, unicode_format.h is only used in unicodeobject.c

[issue24939] Remove unicode_format.h from stringlib

Eric V. Smith added the comment: Actually, int.__format__, etc. are not in this file. So that's good. The things that are in this file but are unrelated to unicodeobject.c are the support routines for implementing string.Formatter. I think I'll move those elsewhere, as a first step. -

[issue24939] Remove unicode_format.h from stringlib

Changes by Eric V. Smith : -- title: Remove unicode_fornat.h from stringlib -> Remove unicode_format.h from stringlib ___ Python tracker ___