[issue24916] In sysconfig, don't rely on sys.version format

2020-03-21 Thread STINNER Victor
STINNER Victor added the comment: Since this issue has been closed, I closed PR 10321 and PR 18487. -- nosy: +vstinner ___ Python tracker ___ _

[issue24916] In sysconfig, don't rely on sys.version format

2020-03-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 684d2b9a071fa8e54749e0eec3c16aafcd642ed4 by Serhiy Storchaka in branch 'master': bpo-24916: Remove an outdated comment. (GH-19101) https://github.com/python/cpython/commit/684d2b9a071fa8e54749e0eec3c16aafcd642ed4 --

[issue24916] In sysconfig, don't rely on sys.version format

2020-03-21 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue24916] In sysconfig, don't rely on sys.version format

2020-03-21 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +18461 pull_request: https://github.com/python/cpython/pull/19101 ___ Python tracker ___

[issue24916] In sysconfig, don't rely on sys.version format

2020-03-17 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue24916] In sysconfig, don't rely on sys.version format

2020-03-17 Thread Thomas Kluyver
Thomas Kluyver added the comment: Serhiy, I think you fixed the part that was actually likely to cause problems a few years ago in issue #25985 & commit 885bdc4946890f4bb80557fab80c3874b2cc4d39 . Using sys.version[:3] to get a short version like 3.8 was what I wanted to fix. People are pres

[issue24916] In sysconfig, don't rely on sys.version format

2020-03-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What is the problem with the current code? -- ___ Python tracker ___ ___ Python-bugs-list maili

[issue24916] In sysconfig, don't rely on sys.version format

2020-02-12 Thread STINNER Victor
STINNER Victor added the comment: The "py_version" variable of sysconfig is discussed since 2015 but... it's unused. It is supposed to build paths. Does it really make sense to build a path which contains "+"? It can confuse some application which may associate a special meaning to "+". Wha

[issue24916] In sysconfig, don't rely on sys.version format

2020-02-12 Thread Daniel Bengtsson
Change by Daniel Bengtsson : -- pull_requests: +17860 pull_request: https://github.com/python/cpython/pull/18487 ___ Python tracker ___

[issue24916] In sysconfig, don't rely on sys.version format

2018-11-04 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Following up on https://github.com/python/cpython/pull/10321#discussion_r230604393 I would like to summarise here what's been going on, in order to move the discussion here forward. I've tried to make a PR for this issue, in which _PY_VERSION in Lib/sys

[issue24916] In sysconfig, don't rely on sys.version format

2018-11-04 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +9623 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue24916] In sysconfig, don't rely on sys.version format

2018-10-31 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I'm working on changing _PY_VERSION to get its value from sys.version_info instead of sys.version, but I am not sure what the best way is to map between a release stage to the corresponding letter(release->rc). Could someone help me a tiny bit with this

[issue24916] In sysconfig, don't rely on sys.version format

2018-10-28 Thread Ned Deily
Ned Deily added the comment: Noted in passing: while Lib/distutils/sysconfig.py has not implemented "py_version", I see now that Lib/distutils/command/install.py does have something very similar to Lib/sysconfig.py so whatever (if anything) is changed in one should also be changed in the oth

[issue24916] In sysconfig, don't rely on sys.version format

2016-02-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Most changes were committed in issue25985. Only _PY_VERSION is left. I have no strong opinion about this, but +0 for keeping "+". -- ___ Python tracker _

[issue24916] In sysconfig, don't rely on sys.version format

2016-02-10 Thread Ned Deily
Ned Deily added the comment: My understanding is that the "+" is added to the PY_VERSION in Include/patchlevel.h by the release management process after any tagged release, whether pre-release or final. So '+" is supposed to be set whenever CPython is built from anything other than an officia

[issue24916] In sysconfig, don't rely on sys.version format

2016-02-10 Thread Martin Panter
Martin Panter added the comment: I just added the dependency to reflect that the patch here will need updating. The main concern here is Thomas’s question: does it matter that py_version loses prerelease info? -- ___ Python tracker

[issue24916] In sysconfig, don't rely on sys.version format

2016-02-10 Thread STINNER Victor
STINNER Victor added the comment: @Serhiy: Can you please take a look since this issue now depends on your issue #25985? -- nosy: +haypo, serhiy.storchaka ___ Python tracker ___

[issue24916] In sysconfig, don't rely on sys.version format

2016-02-08 Thread Martin Panter
Martin Panter added the comment: Issue 25985 also touches the _PY_VERSION_SHORT parts of this. -- dependencies: +Use sys.version_info instead of sys.version nosy: +martin.panter stage: -> patch review ___ Python tracker

[issue24916] In sysconfig, don't rely on sys.version format

2015-08-22 Thread Thomas Kluyver
New submission from Thomas Kluyver: sysconfig currently calculates various formats of the Python version number by chopping up the sys.version string. This has a FIXME by it in the code, because the the format of sys.version is not guaranteed. With this patch, the config variables 'py_version'