[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: 9. As of now, values are not named, whereas I believe they are in debugger. IE given def f(a,b,c): 1/0; f(1,2,3), viewer prints unlaabelled 1, 2, 3 on separate lines. Also, the representation of a value may not fit on a line. I believe a current debugger

[issue24790] Idle: improve stack viewer

Change by STINNER Victor : -- keywords: -easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: Deleted .keys in 8.6. -- versions: -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker ___ ___ P

[issue24790] Idle: improve stack viewer

Roundup Robot added the comment: New changeset 514f5d610175 by Terry Jan Reedy in branch '2.7': Issue #24790: correct typo noticed by Eric Smith https://hg.python.org/cpython/rev/514f5d610175 New changeset 213ae5626493 by Terry Jan Reedy in branch '3.4': Issue #24790: correct typo noticed by Eri

[issue24790] Idle: improve stack viewer

Roundup Robot added the comment: New changeset 14ac7deba91f by Terry Jan Reedy in branch '2.7': Issue #24790: Restore unused function. https://hg.python.org/cpython/rev/14ac7deba91f New changeset eec5e81b38d1 by Terry Jan Reedy in branch '3.4': Issue #24790: Restore unused function. https://hg.p

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: Please post a 'checkpoint' patch with all changes so far, even though it has the 'other globals' problem. Then look at the UI parts of Debugger.py. It has a Stackviewer class that subclasses ScrolledLIst instead of TreeWidget and a Namespaceviewer class curre

[issue24790] Idle: improve stack viewer

Can İbanoğlu added the comment: First of all, sorry for the late reply. I did try the solution you have proposed which removes the need to click to expand the items under globals/locals but as I understand it, you have something more in mind for the whole stackviewer UI. Should I still submit

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: We should take a look as the stackviewer part of the debugger ui. -- ___ Python tracker ___ ___ Pyth

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: I just realized that there is a slight but in the patch so far. When a non-empty program runs, it necessarily executes at least one statement in the main module. It will only execute anything else when there is a call. Therefore, the stack trace always begin

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: NEWS patches should be omitted from submitted .diff or .patch files because a) NEWS is so volatile that merge conflicts applying the .diff are likely; b) NEWS is different between versions, so that forward merge conflicts are possible (usual for Idle items, so

[issue24790] Idle: improve stack viewer

Can İbanoğlu added the comment: Come to think of it, maybe I should send both the second and third items in one patch? I could just call the GetSubList method if the VariablesTreeItem is being created for locals. Is that a bad approach to take? Sorry for the sheer number of questions :) -

[issue24790] Idle: improve stack viewer

Can İbanoğlu added the comment: I have also prepared a patch for the second item but I don't know if I should regenerate the patch after you have committed the first patch so I'm sitting on it now. I also didn't update the ACKS and NEWS files, should I? Here's what I did for the second item,

[issue24790] Idle: improve stack viewer

Can İbanoğlu added the comment: Alright, here goes my first patch. I just did what you have pointed out :) -- keywords: +patch Added file: http://bugs.python.org/file40213/issue24790.1.patch ___ Python tracker

[issue24790] Idle: improve stack viewer

Can İbanoğlu added the comment: Thank you very much for your thorough input, it is very much appreciated! Actually one of the first things that I tried was to return stack[1:] to remove the target but your suggestion is much better. I did try it and it does work and I will provide a patch as s

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: A fair question. The API is a private implementation for Idle (see PEP 434), though I am generally avoiding breaking any public uses thereof. I actually checked that the method is not defined on the base class. But on the microchance that someone uses it, I

[issue24790] Idle: improve stack viewer

Jim Jewett added the comment: Terry: Was removing the public attribute keys OK? -- nosy: +Jim.Jewett ___ Python tracker ___ ___ Pytho

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: 7. Sorts global and local names (as with dir()). 8. Don't expand values with their class attributes, at least not for builtins. Example + __doc__ = None Clicking + gives all the attributes of type(None), each with its own +. It does not do this for ints

[issue24790] Idle: improve stack viewer

Roundup Robot added the comment: New changeset 9ad330a9d785 by Terry Jan Reedy in branch '2.7': Issue #24790: Remove extraneous code (which also create 2 & 3 conflicts). https://hg.python.org/cpython/rev/9ad330a9d785 New changeset 010264c9ceae by Terry Jan Reedy in branch '3.4': Issue #24790: Re

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: StackViewer.py seem to be identical in 3.4, 3.5, and 3.6, so a patch against any applies to all. The diff with 2.7 is F:\Python\dev\36>hg diff -r 4884af6d3e30 f:/python/dev/36/Lib/idlelib/StackViewer.py @@ -2,7 +2,7 @@ import sys import linecache import re

[issue24790] Idle: improve stack viewer

Can İbanoğlu added the comment: Hello again, I have spent some time going over the code and how the PyShell brings all of this together and have formed some loose opinions on how to solve these issues but I wanted to get a much more informed opinion. I will provide a patch for the first one f

[issue24790] Idle: improve stack viewer

Changes by Mark Roseman : -- nosy: +markroseman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue24790] Idle: improve stack viewer

Can İbanoğlu added the comment: It does indeed, thank you very much! I have signed the Contributor Agreement and will start working on this right away. -- ___ Python tracker ___

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: Welcome. I was hoping a new contributor would see the 'easy' tag. Nervous is okay as long as it leads to heighten carefulness without paralysis. I am still nervous hitting the [Commit] button. 1. Important. Sign the contributor agreement. https://www.python.o

[issue24790] Idle: improve stack viewer

Can İbanoğlu added the comment: Hello, I'm very interested in tackling this issue but this will be my first contribution to Python and I'm quite nervous. I have gone over the developer guide and FAQ but I would appreciate if you could let me know if I should approach this in a certain way.

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: 5b. Add Python version to end of , as with Shell window. This will be more than one patch. Some should be easy. -- keywords: +easy ___ Python tracker _

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: 5. Change title to something better than 'Idle'. Perhaps 'Idle Shell Traceback'? -- ___ Python tracker ___ ___

[issue24790] Idle: improve stack viewer

New submission from Terry J. Reedy: Debug => Stack Viewer (no hot key) could become more useful, aside from #23544, freezing Idle when Debugger active. 1. Don't include idlelib.run.runcode. 2. Don't duplicate globals under each function. Once for the module is enough. 3. Remove +Locals under ea