[issue24773] Implement PEP 495 (Local Time Disambiguation)

STINNER Victor added the comment: Two bugs were found in the implementation: issue #29100 and issue #29140. -- ___ Python tracker ___

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Roundup Robot added the comment: New changeset 5c02f689c62c by Victor Stinner in branch '3.6': Issue #24773: fix datetime.time constructor docstring https://hg.python.org/cpython/rev/5c02f689c62c -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: As far as I can tell, the buildbots are happy now. Closing. Please open new issues if missed anything. -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Roundup Robot added the comment: New changeset 617104a6b759 by Alexander Belopolsky in branch 'default': Issue #24773: Include Tallinn 1999-10-31 transition in tests. https://hg.python.org/cpython/rev/617104a6b759 -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Roundup Robot added the comment: New changeset 71a7db7ceabc by Alexander Belopolsky in branch 'default': Issue #24773: Skip system tests for transitions in year 2037 and later. https://hg.python.org/cpython/rev/71a7db7ceabc -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Martin Panter added the comment: Both parts of your commit seem to have helped. However I found two failures still happening, and one new failure: 1. Casablanca and El_Aaiun still failing since the original commit: http://buildbot.python.org/all/builders/PPC64%20Fedora%203.x/builds/1318/steps/t

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Roundup Robot added the comment: New changeset 05120447f2c6 by Alexander Belopolsky in branch 'default': Issue #24773: Fix and speed-up ZoneInfoCompleteTest. https://hg.python.org/cpython/rev/05120447f2c6 -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: > Can the size of the tests be reduced, [...]? Yes, the long test walks the zoneinfo tree and runs on every tzfile including the aliases. I am going to change that to parsing the zone.tab file for the list of zone names. This should shorten the time at

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: > Any news on the remaining failures for year 2037? Yes, the problem was tracked to a bug [1] in zic. If the buildbots get regular updates, the problem will go away with the next tzdata release. Meanwhile, I'll try to figure out a way to suppress the e

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Martin Panter added the comment: Any news on the remaining failures for year 2037? What about the buildbots that time out? Can the size of the tests be reduced, or perhaps should the buildbots be updated to extend the timeout? -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

koobs added the comment: Thank you Alexander, consider me satisfied :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Roundup Robot added the comment: New changeset eed3a5b9239f by Alexander Belopolsky in branch 'default': Issue 24773: Use the standard Asia/Tehran name in the Iran test. https://hg.python.org/cpython/rev/eed3a5b9239f -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: > I don't know to what extent these links are considered standard (koobs) The links like Iran are non-standard. they are specified in the "backward" file in the IANA tzdata distribution which has the following preamble: # This file provides links betwee

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: It looks like the tzdata folks have agreed [1] that there is a problem with the Morocco rules in the Africa file and will likely fix it in the next release. This is an interesting situation where a bug in tzcode masks a bug in tzdata while glibc implemen

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: It looks like Ruby folks encountered the Morocco issue [1] before us. They closed the issue on their bug tracker blaming glibc. This tells us, I guess, that we should skip this transition on the affected systems. Unfortunately, it is not just 32-bit t

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: It looks like th Morocco issue has been reported to CentOS recently but they kicked it upstream. https://sourceware.org/ml/libc-help/2016-04/msg0.html -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: Also reported for Ubuntu: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1587128 -- ___ Python tracker ___

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: It looks like PPC64 Fedora 3.x builder [1] also has a problem with a transition in 2037. [1]: http://buildbot.python.org/all/builders/PPC64%20Fedora%203.x -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Roundup Robot added the comment: New changeset 95df96aa2f5a by Alexander Belopolsky in branch 'default': Issue #24773: Fixed tests failures on systems with 32-bit time_t. https://hg.python.org/cpython/rev/95df96aa2f5a -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Martin Panter added the comment: Just confirming that my Casablanca failure is restricted to the 32-bit build, though I think you already figured this out. -- ___ Python tracker ___

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: Could our Morocco issue be similar to Fiji issue? https://github.com/eggert/tz/commit/6d00980f1ff2ac665f3de027c79faacf4f26d1b0 -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: The remaining failures all seems to be related to the Morocco rules: both Africa/El_Aaiun [1] and Africa/Casablanca [2] use those rules. The affected date is October 4, 2037, for which Morocco has a special rule. [3] It looks like the problem is with th

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Roundup Robot added the comment: New changeset 8cc06070e98b by Alexander Belopolsky in branch 'default': Issue 24773: Added a time_t overflow check. https://hg.python.org/cpython/rev/8cc06070e98b -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

koobs added the comment: koobs-freebsd-* 3.x builds are now passing, but I'd like to make an additional (trivial) proposal, and that is: If the tests that were previously failling, aren't *specifically* testing for 'backward compatible' timezone definitions, that the tests that currently use

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: That's very helpful. It looks like on a Mac 32-bit build has 64-bit time_t. I'll build a 32-bit Python on Linux tomorrow and try to get to the bottom of this. -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Martin Panter added the comment: I _think_ the system_transitions failure only happens for 32 bit (have to test more to be sure). (My 32-bit environment is lacking many libraries compared to main 64-bit environment, but still uses the same filesystem etc.) First system_transitions failure with

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Martin Panter added the comment: Without blocking the C implementation _datetime, I get both extremes causing OverflowError: >>> import datetime, time, os >>> os.environ["TZ"] = "EST+05EDT,M3.2.0,M11.1.0" >>> time.tzset() >>> t = datetime.datetime(2,1,1) >>> s = t.timestamp() >>> s -12223358494

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Roundup Robot added the comment: New changeset dca143512f6e by Alexander Belopolsky in branch 'default': Issue 24773: Make zoneinfo tests more robust. (reapply) https://hg.python.org/cpython/rev/dca143512f6e -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Roundup Robot added the comment: New changeset ae19ea7c36e6 by Alexander Belopolsky in branch 'default': Issue #24773: Made ZoneInfoCompleteTest a TestSuit. https://hg.python.org/cpython/rev/ae19ea7c36e6 -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: Looking at the stable buildbots. http://buildbot.python.org/all/waterfall?category=3.x.stable AMD64 OpenIndiana 3.x - unrelated failures AMD64 Snow Leop 3.x - crash in test_all / system_transitions PPC64 Fedora 3.x - fail in test_all Africa/El_Aaiun syste

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: > the time_t OverflowError The issue here is that for a large date, dt.timestamp() returns a float large enough to cause overflow in fromtimestamp. > Let me know if you want any more info. Can you figure out what date causes this (0002-01-01 or 9998-12-

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Martin Panter added the comment: FWIW I can produce two of these failures locally: the time_t OverflowError, and the test_all() system_transitions one. Let me know if you want any more info. In my case the message for the test_all() failure is “posix/Africa/Casablanca system_transitions”. I am

[issue24773] Implement PEP 495 (Local Time Disambiguation)

koobs added the comment: See Also: non standard (standard?) timezones. https://lists.freebsd.org/pipermail/freebsd-hackers/2015-May/047765.html I don't know to what extent these links are considered standard, but I'll talk to Julian about whether we can get these links installed in FreeBSD bas

[issue24773] Implement PEP 495 (Local Time Disambiguation)

koobs added the comment: I can help providing information on the koobs-* freebsd buildbots (I run them). In a default installation, the timezone entries are available in /usr/share/zoneinfo (see attachment for contents) Iran is not in the root directory, 'Tehran' is in Asia/ subdirectory tzs

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: > AssertionError: False is not true : Africa/El_Aaiun system_transitions This may be an indication of misconfigured zoneinfo on the buildbot. What system_transitions test does is compare the results obtained from the system timezone computations to the

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Roundup Robot added the comment: New changeset e72aab080165 by Alexander Belopolsky in branch 'default': Issue 24773: Make zoneinfo tests more robust. https://hg.python.org/cpython/rev/e72aab080165 -- ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: Does anyone know whether zoneinfo is installed on FreeBSD buildbot? If it is, at which path? > On Jul 23, 2016, at 7:24 AM, koobs wrote: > > > koobs added the comment: > > Also failing on all freebsd buildbots, all tests failing with: > > FileNotFou

[issue24773] Implement PEP 495 (Local Time Disambiguation)

koobs added the comment: Also failing on all freebsd buildbots, all tests failing with: FileNotFoundError: [Errno 2] No such file or directory: '/usr/share/zoneinfo/Iran' -- nosy: +koobs resolution: fixed -> ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Martin Panter added the comment: FYI, other failures that may be different problems: http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/4930/steps/test/logs/stdio Timeout (0:15:00)! Thread 0x7fff71296cc0 (most recent call first): File "/Users/buildbot/buildarea/3.x.m

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Martin Panter added the comment: This upset the buildbots: http://buildbot.python.org/all/builders/PPC64%20Fedora%203.x/builds/1259/steps/test/logs/stdio == FAIL: test_all (test.datetimetester.ZoneInfoCompleteTest) -

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Changes by Alexander Belopolsky : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed superseder: -> Document PEP 495 (Local Time Disambiguation) features ___ Python tracker __

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Roundup Robot added the comment: New changeset 7c0917670ab8 by Alexander Belopolsky in branch 'default': Closes issue #24773: Implement PEP 495 (Local Time Disambiguation). https://hg.python.org/cpython/rev/7c0917670ab8 -- nosy: +python-dev ___ Python

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: I am posting the final version of the patch complete with the NEWS entry. Compared with the previous patch, issue24773-final.diff contains a fix for a reference leak. I would like to use this opportunity to thank Zachary Ware for providing a Windows VM

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: The new patch passes test_datetime on Windows. This was the last stumbling block for me to commit this patch. Unless anyone would ask for more time to review, I plan to commit later this week. -- Added file: http://bugs.python.org/file43781/iss

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: Naoki, thanks for the review. I addressed your comments in https://github.com/abalkin/cpython/commit/a61a25d2dd04336361b2ea676c80afdb2639f579 Attached patch, issue24773-s3-3.diff, incorporates your comments and a few other fixes. See github for the fu

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Changes by Alexander Belopolsky : -- nosy: +haypo stage: needs patch -> commit review ___ Python tracker ___ ___ Python-bugs-list mail

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: Submitting the latest Github snapshot as a patch against master for review. See issue24773-s3-2.diff. -- Added file: http://bugs.python.org/file43753/issue24773-s3-2.diff ___ Python tracker

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Changes by Alexander Belopolsky : -- hgrepos: +335 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Changes by Stuart Bishop : -- nosy: +stub ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Changes by Akira Li <4kir4...@gmail.com>: -- nosy: +akira ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Changes by Tim Peters : -- nosy: +tim.peters ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Changes by Alexander Belopolsky : Added file: http://bugs.python.org/file40614/issue24773-s3.diff ___ Python tracker ___ ___ Python-bugs-list

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: Changing the title to reference PEP 495. -- stage: -> needs patch title: Add local time disambiguation flag to datetime -> Implement PEP 495 (Local Time Disambiguation) ___ Python tracker