[issue24288] Include/opcode.h is modified during building

2016-12-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Please open new issue Tres. If it is not opened. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue24288] Include/opcode.h is modified during building

2016-12-27 Thread Tres Seaver
Changes by Tres Seaver : -- title: permissions -> Include/opcode.h is modified during building ___ Python tracker ___ ___ Python-bugs-

[issue24288] Include/opcode.h is modified during building

2016-12-27 Thread Tres Seaver
Tres Seaver added the comment: ISTM that this issue should be re-opened, because it breaks out-of-tree building from a pristine / read-only source tree. If they are "public" headers, files like 'opcode.h' should be generated and checked in as part of the release process, rather than modified

[issue24288] Include/opcode.h is modified during building

2015-05-27 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue24288] Include/opcode.h is modified during building

2015-05-27 Thread Yury Selivanov
Yury Selivanov added the comment: lgtm -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue24288] Include/opcode.h is modified during building

2015-05-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think the intension was to produce aligned data, but the alignment of the second column was wrong. Here is a patch that corrects formatting. -- stage: needs patch -> patch review Added file: http://bugs.python.org/file39517/generate_opcode_h_align.p

[issue24288] Include/opcode.h is modified during building

2015-05-26 Thread Yury Selivanov
Yury Selivanov added the comment: > Other solution is to change Tools/scripts/generate_opcode_h.py to generate a > file without trailing spaces. I like this option. I saw the whitespace, but I usually don't touch autogenerated files, so I naturally thought that someone has modified the toolin

[issue24288] Include/opcode.h is modified during building

2015-05-26 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Changeset eeeb666a5365 in issue24017 unintentionally changed formatting of generated file Include/opcode.h. Now clean building CPython modifies Include/opcode.h. One solution is to restore formatting of Include/opcode.h (regenerate it and commit). Other