[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

Robert Collins added the comment: Debian is green again and I think windows will do so to. -- stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ ___

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

Robert Collins added the comment: So it looks like one failure is: FAIL: test_getline (test.test_linecache.GoodUnicode) -- Traceback (most recent call last): File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\tes

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

Robert Collins added the comment: I can't see how the patch could have caused the Traceback (most recent call last): File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_symbol.py", line 44, in test_real_grammar_and_symbol_file os.stat(TEST_PY_FILE))) AssertionError

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

David Edelsohn added the comment: Also http://buildbot.python.org/all/builders/s390x%20Debian%203.x/builds/2/steps/test/logs/stdio http://buildbot.python.org/all/builders/s390x%20Debian%203.x/builds/2 Comments Issue #24054: decouple linecache tests from inspect tests Patch from David D. Ridd

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

R. David Murray added the comment: Example: http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/10098/steps/test/logs/stdio -- nosy: +r.david.murray stage: resolved -> needs patch status: closed -> open ___ Python tracker

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

Changes by David Edelsohn : -- nosy: +David.Edelsohn -David Edelsohn ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

David Edelsohn added the comment: This patch causes a new failure on many of the buildbots. -- nosy: +David Edelsohn ___ Python tracker ___ __

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

Robert Collins added the comment: Thank you for the patch; sorry it took me so long to get to it - been working on a backlog of patch review. -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

Roundup Robot added the comment: New changeset fc56a0300cd4 by Robert Collins in branch 'default': Issue #24054: decouple linecache tests from inspect tests https://hg.python.org/cpython/rev/fc56a0300cd4 -- nosy: +python-dev ___ Python tracker

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

David D. Riddle added the comment: Here is another patch. I fixed a bug in GetLineTestsBadData.test_getline and refactored the code. I think everything is good now. As for the ResourceWarnings they are not caused by linecache. The problem is with tokenize.open (See http://bugs.python.org/issue

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

David D. Riddle added the comment: I have made the changes you suggested. Please tell me if any further changes are needed. > The unclosed file suggests a cleanup bug in linecache which we should > fix for hygiene, but is separate :) Should I file a bug report? -- Added file: http://b

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

David D. Riddle added the comment: I have made the changes you suggested. Please look at lines 87-97. I am not certain if that is correct behavior. I was surprised that a SyntaxError is thrown in addition to the UnicodeDecodeError when linecache.getlines takes a file with bad unicode. Please t

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

Robert Collins added the comment: Thanks, I shall look at this Monday. -- nosy: +rbcollins ___ Python tracker ___ ___ Python-bugs-list

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

New submission from David D. Riddle: test_linecache.py reads from three files namely inspect_fodder.py, inspect_fodder2.py, and mapping_tests.py. It reads the py files directly as text files. This patch copies these files to linecache_fodder, linecache_fodder2, and linecache_mapping_fodder res