[issue23998] PyImport_ReInitLock() doesn't check for allocation error

Christian Heimes added the comment: Thanks, Brett! -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue23998] PyImport_ReInitLock() doesn't check for allocation error

Roundup Robot added the comment: New changeset d70995cf44b3 by Christian Heimes in branch '2.7': Issue #23998: PyImport_ReInitLock() now checks for lock allocation error https://hg.python.org/cpython/rev/d70995cf44b3 New changeset 7d7bf5c34d7e by Christian Heimes in branch '3.3': Issue #23998: P

[issue23998] PyImport_ReInitLock() doesn't check for allocation error

Brett Cannon added the comment: LGTM -- assignee: -> christian.heimes nosy: +brett.cannon stage: patch review -> commit review ___ Python tracker ___ ___

[issue23998] PyImport_ReInitLock() doesn't check for allocation error

New submission from Christian Heimes: _PyImport_ReInitLock() doesn't check the return value of PyThread_allocate_lock(). A failed lock allocation can either lead to a NULL pointer dereference or to race conditions caused by a missing import lock. As there is no way to recover from a failed loc