[issue23785] Leak in TextIOWrapper.tell()

2015-03-30 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue23785] Leak in TextIOWrapper.tell()

2015-03-30 Thread Roundup Robot
Roundup Robot added the comment: New changeset 442ebebad516 by Serhiy Storchaka in branch '3.4': Issue #23785: Fixed memory leak in TextIOWrapper.tell() in rare circumstances. https://hg.python.org/cpython/rev/442ebebad516 New changeset 2fcd99929dba by Serhiy Storchaka in branch 'default': Issue

[issue23785] Leak in TextIOWrapper.tell()

2015-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Just reading the code that uses PyErr_Restore(). I found 3 issues and may be the fourth in sqlite (it is more complicate than other 3). -- ___ Python tracker ___

[issue23785] Leak in TextIOWrapper.tell()

2015-03-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: How did you notice it, btw? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue23785] Leak in TextIOWrapper.tell()

2015-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It would be not easy to reproduce without special broken decoder. -- ___ Python tracker ___ ___ Py

[issue23785] Leak in TextIOWrapper.tell()

2015-03-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: lgtm with a test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue23785] Leak in TextIOWrapper.tell()

2015-03-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- keywords: +patch Added file: http://bugs.python.org/file38699/issue23785.patch ___ Python tracker ___ ___

[issue23785] Leak in TextIOWrapper.tell()

2015-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Proposed patch chain original exception to the exception raised by setstate(saved_state). This matches the behavior of Python implementation. -- stage: -> patch review ___ Python tracker

[issue23785] Leak in TextIOWrapper.tell()

2015-03-26 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: If an exception was raised in TextIOWrapper.tell() and then restoring state is failed, original exception is lost and leaked. -- components: Extension Modules messages: 239327 nosy: benjamin.peterson, haypo, pitrou, serhiy.storchaka, stutzbach prior