[issue23641] Got rid of bad dunder names

Serhiy Storchaka added the comment: I'm not sure about removing __getslice__ and __setslice__ from multiprocessing.sharedctypes and __div__ from unittest.mock, and left them as is. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue23641] Got rid of bad dunder names

Roundup Robot added the comment: New changeset 75cec736f87d by Serhiy Storchaka in branch '3.5': Issue #23641: Added __getnewargs_ex__ to the list of special mock attributes. https://hg.python.org/cpython/rev/75cec736f87d New changeset 4c5f7b61b6c5 by Serhiy Storchaka in branch 'default': Issue

[issue23641] Got rid of bad dunder names

Serhiy Storchaka added the comment: Committed all except changes to multiprocessing.sharedctypes (remove __getslice__ and __setslice__) and unittest.mock (remove __div__, add __getnewargs_ex__). -- ___ Python tracker

[issue23641] Got rid of bad dunder names

Roundup Robot added the comment: New changeset 7522bb14e36a by Serhiy Storchaka in branch '3.4': Issue #23641: Cleaned out legacy dunder names from tests and docs. https://hg.python.org/cpython/rev/7522bb14e36a New changeset 9332a545ad85 by Serhiy Storchaka in branch 'default': Issue #23641: Cle

[issue23641] Got rid of bad dunder names

Berker Peksag added the comment: > Do you want first commit the patch in issue23581 Berker? I just committed it. Thanks for the review :) -- ___ Python tracker ___ _

[issue23641] Got rid of bad dunder names

Serhiy Storchaka added the comment: Do you want first commit the patch in issue23581 Berker? -- ___ Python tracker ___ ___ Python-bugs

[issue23641] Got rid of bad dunder names

Martin Panter added the comment: I’m not very familiar with the mock module so can't comment if removing div is sensible there. But all the other changes seem reasonable. I just left a few suggestions for further tweaks on Rietveld. -- nosy: +vadmium __

[issue23641] Got rid of bad dunder names

Changes by Serhiy Storchaka : -- dependencies: +unittest.mock.MagicMock doesn't support matmul (@) operator ___ Python tracker ___ ___

[issue23641] Got rid of bad dunder names

Berker Peksag added the comment: > Also added support for __matmul__ and __getnewargs_ex__ in unittest.mock [...] See issue 23581 for __matmul__ support. -- nosy: +berker.peksag ___ Python tracker

[issue23641] Got rid of bad dunder names

New submission from Serhiy Storchaka: Proposed patch gets rid of uses and mentions of bad dunder names. I.e. names inherited from Python 2: __cmp__, __nonzero__, __getslice__, __unicode__, __div__, etc. They are replaced by correct names (__truediv__, __floordiv__, __eq__, __bool__, etc) or re