[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Roundup Robot added the comment: New changeset 55f7a99a5433 by Gregory P. Smith in branch '3.5': Fixes #23564: Fix a partially broken sanity check in the _posixsubprocess https://hg.python.org/cpython/rev/55f7a99a5433 New changeset 97e2a6810f7f by Gregory P. Smith in branch 'default': Fixes #235

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Gregory P. Smith added the comment: I didn't bother adding the fix to 3.4, it isn't high value. -- resolution: -> fixed status: open -> closed versions: +Python 3.5, Python 3.6 ___ Python tracker _

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Gregory P. Smith added the comment: heh, you're right. it's a trivial obvious fix for the mistake in the existing implementation. writing a test and committing. the other option would be to get rid of the sanity check entirely or change it not to use the odd "require a sorted list" code. bu

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Martin Panter added the comment: FWIW I think this patch is trivial enough not to need an agreement. -- nosy: +martin.panter ___ Python tracker ___ __

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Gregory P. Smith added the comment: Hisham, could you sign the Python contributor agreement? https://www.python.org/psf/contrib/contrib-form/ thanks! -- ___ Python tracker ___

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Gregory P. Smith added the comment: Haha, yes, that description and patch look correct. Thanks! Fortunately this bug is low impact as this was just a sanity check and the calling code from subprocess.py was already passing the correct data in. An ideal regression test: An explicit unittest th

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Changes by Ned Deily : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

New submission from Hisham Muhammad: In Modules/_posixsubprocess.c, (the helper module for Lib/subprocess.py) there's a function called _sanity_check_python_fd_sequence which checks, as its comment says, if the fds in the sequence are all positive and sorted. The check to verify if it is sorte