[issue23347] asyncio: fix and refactor creation of subprocess transports

2018-09-12 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset aca819fb494d4801b3e5b5b507b17cab772c1b40 by Yury Selivanov (Bumsik Kim) in branch 'master': bpo-33649: Fix doc to reflect changes in 47cd10d (or bpo-23347) (GH-9219) https://github.com/python/cpython/commit/aca819fb494d4801b3e5b5b507b17cab772c1b

[issue23347] asyncio: fix and refactor creation of subprocess transports

2015-01-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset c1d92f7221a5 by Victor Stinner in branch '3.4': Issue #23347, asyncio: send_signal(), terminate(), kill() don't check if the https://hg.python.org/cpython/rev/c1d92f7221a5 -- ___ Python tracker

[issue23347] asyncio: fix and refactor creation of subprocess transports

2015-01-29 Thread STINNER Victor
STINNER Victor added the comment: I commited my change with small changes. "wait() is a coroutine, which is something uncommon. Is it ok to start using coroutines in transports, at least for subprocess transports?" I made the method private (renamed to _wait()). -- resolution: -> fix

[issue23347] asyncio: fix and refactor creation of subprocess transports

2015-01-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset dadc372f46fa by Victor Stinner in branch '3.4': Issue #23347, asyncio: Make BaseSubprocessTransport.wait() private https://hg.python.org/cpython/rev/dadc372f46fa -- ___ Python tracker

[issue23347] asyncio: fix and refactor creation of subprocess transports

2015-01-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset a5efd5021ca1 by Victor Stinner in branch '3.4': asyncio: sync with Tulip https://hg.python.org/cpython/rev/a5efd5021ca1 -- nosy: +python-dev ___ Python tracker ___

[issue23347] asyncio: fix and refactor creation of subprocess transports

2015-01-29 Thread STINNER Victor
New submission from STINNER Victor: Attached patch fix and refactors the creation of asyncio subprocess transports. It fixes the code handling errors. Changes: * Add a wait() method to wait until the child process exit * The constructor now accepts an optional waiter parameter. The _post_init