[issue23304] Unused Superclass in calendar.py

Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23304] Unused Superclass in calendar.py

Changes by Serhiy Storchaka : -- resolution: -> not a bug status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23304] Unused Superclass in calendar.py

Serhiy Storchaka added the comment: I suppose that calendar.error is here for compatibility. It is an alias to ValueError, so that errors raised by the calendar module can be catched with the "except calendar.error:" statement. Making calendar.error different class will likely break user code.

[issue23304] Unused Superclass in calendar.py

Berker Peksag added the comment: Looks like "error" was unused since https://hg.python.org/cpython/rev/acdc0b9a6c78#l2.48 (see also https://hg.python.org/cpython/rev/6ee380349c84/ for time.gmtime()). LGTM. -- nosy: +berker.peksag stage: -> commit review _

[issue23304] Unused Superclass in calendar.py

Vipul Sharma added the comment: I am submitting a patch file, hope this works. Please review it and correct me if I am wrong anywhere as this is my first contribution. -- keywords: +patch nosy: +Vipul.Sharma Added file: http://bugs.python.org/file37891/calendar_1.patch

[issue23304] Unused Superclass in calendar.py

Changes by SilentGhost : -- keywords: +easy versions: +Python 3.5 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23304] Unused Superclass in calendar.py

New submission from CliffM: calendar.py ( lines 17,18 ) is not used : # Exception raised for bad input (with string parameter for details) error = ValueError This could either be deleted OR used as the superclass in the next two class declarations as the comment suggests. -- componen