[issue23302] Small fixes around the use of TCP MSS in http.client

Roundup Robot added the comment: New changeset 42971b769c0b by Benjamin Peterson in branch 'default': http.client: disable Nagle's algorithm (closes #23302) https://hg.python.org/cpython/rev/42971b769c0b -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> close

[issue23302] Small fixes around the use of TCP MSS in http.client

Demian Brecht added the comment: I've attached a new patch disabling Nagle by default, but doing so in connect() as to allow users to override it if they really want to. I've also removed the use of mss in HTTPConnection. This is a backwards incompatible change in two ways: 1. Removing mss as

[issue23302] Small fixes around the use of TCP MSS in http.client

Demian Brecht added the comment: I'm not opposed to that either. The only downside really (at least as far as I'm aware) is the potential substantial influx of packets should an iterable comprised of small chunks of data be passed in as the body, although I would consider that quite a strange

[issue23302] Small fixes around the use of TCP MSS in http.client

Charles-François Natali added the comment: Or we should acknowledge that this is overkill, and take the same approach as all major web browser: disable the Nagle algorithm. For a protocol like http which is transaction oriented it's probably the best thing to do. -- nosy: +neologix, pi

[issue23302] Small fixes around the use of TCP MSS in http.client

Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue23302] Small fixes around the use of TCP MSS in http.client

Changes by Demian Brecht : -- components: +Library (Lib) keywords: +patch versions: +Python 3.5 Added file: http://bugs.python.org/file37822/issue23302.patch ___ Python tracker _

[issue23302] Small fixes around the use of TCP MSS in http.client

New submission from Demian Brecht: There are a couple of small issues with the determination of whether or not a request can fit in a single TCP/IP packet in http.client. 1. The MSS is hardcoded 2. The TCP data size is calculated as only the message body. This is incorrect as the size of the H