[issue22721] pprint output for sets and dicts is not stable

Serhiy Storchaka added the comment: Thank you for your review Fred. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue22721] pprint output for sets and dicts is not stable

Roundup Robot added the comment: New changeset c8815035116b by Serhiy Storchaka in branch 'default': Issue #22721: An order of multiline pprint output of set or dict containing https://hg.python.org/cpython/rev/c8815035116b -- nosy: +python-dev ___ Py

[issue22721] pprint output for sets and dicts is not stable

Fred L. Drake, Jr. added the comment: Sorry for the delay. pprint_safe_key.patch looks good to me. -- ___ Python tracker ___ ___ Pyth

[issue22721] pprint output for sets and dicts is not stable

Serhiy Storchaka added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue22721] pprint output for sets and dicts is not stable

Serhiy Storchaka added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue22721] pprint output for sets and dicts is not stable

Serhiy Storchaka added the comment: My question to Raymond is should we use the "<" operator or special methods __lt__ and __gt__ (this is the difference between alternative patches)? The use of repr instead of id is different issue. -- ___ Python t

[issue22721] pprint output for sets and dicts is not stable

Antoine Pitrou added the comment: I think it'd be nice if the solution kept the current order when all keys are orderable (which is a very common case). So IMO repr() should only be used as a fallback when the object comparison fails. -- ___ Python

[issue22721] pprint output for sets and dicts is not stable

Serhiy Storchaka added the comment: > How about: repr(obj).strip("'\"") ? String can starts or ends with quotes. And string repr can be a part of the repr of other type (e.g. short list). -- ___ Python tracker _

[issue22721] pprint output for sets and dicts is not stable

Raymond Hettinger added the comment: > the primary sort will be on the type of quote used for the repr, > which would be surprising and significantly less useful. How about: repr(obj).strip("'\"") ? Overall, the idea of using repr() in some fashion is appealing because it sorts on what the us

[issue22721] pprint output for sets and dicts is not stable

Changes by Raymond Hettinger : -- assignee: rhettinger -> fdrake ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22721] pprint output for sets and dicts is not stable

Changes by Raymond Hettinger : -- assignee: -> rhettinger versions: -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue22721] pprint output for sets and dicts is not stable

Fred L. Drake, Jr. added the comment: Sorting by the repr sounds good, but if some dict keys or set members are strings containing single-quotes, the primary sort will be on the type of quote used for the repr, which would be surprising and significantly less useful. -- __

[issue22721] pprint output for sets and dicts is not stable

Amaury Forgeot d'Arc added the comment: What if [some flavor of] pprint sorted items not by value, but by their repr() string? It's probably faster than any other algorithm, and guaranteed to produce consistent results. Or use this idea only for ambiguous cases? -- nosy: +amaury.forge

[issue22721] pprint output for sets and dicts is not stable

Serhiy Storchaka added the comment: And here is alternative patch if the first patch is not correct. It is more complicated and I suppose is less efficient in common case. -- Added file: http://bugs.python.org/file37013/pprint_safe_key_alt.patch ___

[issue22721] pprint output for sets and dicts is not stable

Serhiy Storchaka added the comment: > Hmm... is it important? Not more than sorting pprint output at all. This looks low priority issue to me, but the fix looks pretty easy. Here is a patch. I hope Raymond will make a review, may be I missed some details. -- keywords: +patch stage: -

[issue22721] pprint output for sets and dicts is not stable

Fred L. Drake, Jr. added the comment: Stability in output order from pprint is very useful in doctests (yes, some people write documentation that they test). I think fixing any output stability issues would be very worthwhile. -- ___ Python tracker

[issue22721] pprint output for sets and dicts is not stable

Antoine Pitrou added the comment: Hmm... is it important? -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue22721] pprint output for sets and dicts is not stable

New submission from Serhiy Storchaka: pprint() sorts the content of sets and dicts in order to get stable output which doesn't depend on iteration order of set or dict, which depend not only from values of elements, but also from set or dict history. But in some cases the output is different f