[issue22631] Feature Request CAN_RAW_FD_FRAMES

R. David Murray added the comment: There is no CAN support in 2.7, so no. -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-b

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Larry Hastings added the comment: Benjamin, would you like CAN_RAW_FD_FRAMES in the next 2.7? -- nosy: +benjamin.peterson ___ Python tracker ___ _

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Antoine Pitrou added the comment: It is a new feature. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Larry Hastings added the comment: Isn't this a "new feature"? 2.7 is maybe fair game, but 3.4 arguably is not. It should be odd to have a field marked in the documentation as "New in 3.4.4." -- ___ Python tracker

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Joe Jevnik added the comment: So I think the patch could be applied to 3.4; I will look into moving the other back sometime this week. -- ___ Python tracker ___

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Matthias Klose added the comment: it would be nice to have these constants backported to both 2.7 and 3.4. It may be good to check for other missing consgtants in this module in 2.7 and 3.4. -- nosy: +doko ___ Python tracker

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Larry Hastings added the comment: Patch committed. Thanks, Joe! -- assignee: -> larry resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker __

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Roundup Robot added the comment: New changeset 03ff92b26fa9 by Larry Hastings in branch 'default': Issue #22631: Added Linux-specific socket constant CAN_RAW_FD_FRAMES. https://hg.python.org/cpython/rev/03ff92b26fa9 -- nosy: +python-dev ___ Python tra

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Joe Jevnik added the comment: I tried to provide a summary of the Linux page on the topic and then said that it was fully documented there. -- Added file: http://bugs.python.org/file38957/CAN_RAW_FD_FRAMES-doc.patch ___ Python tracker

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Larry Hastings added the comment: Follow the instructions in this: https://docs.python.org/devguide/docquality.html And make it look something like this: https://docs.python.org/3/library/socket.html#socket.CAN_BCM -- ___ Python tracker

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Joe Jevnik added the comment: I am not going to be able to write docs on this because I am not totally sure how you would use this; There is an entry in the docs for CAN_* so that might be enough. I have a line now saying that this particular flag is available as of 3.5 though. -- Add

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Berker Peksag added the comment: The new constant should probably be added to https://docs.python.org/3/library/socket.html#constants (with a .. versionadded:: 3.5 directive) -- nosy: +berker.peksag stage: -> commit review ___ Python tracker

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Larry Hastings added the comment: LGTM, just adding Antoine (the expert for the socket module). I'm ready to commit over here. -- nosy: +pitrou ___ Python tracker ___ _

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Joe Jevnik added the comment: To show where I got my sources: https://github.com/torvalds/linux/commit/e2d265d3b587f5f6f8febc0222aace93302ff0be There does not appear to be any new structures needed other than supporting the constant. -- nosy: +larry __

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Joe Jevnik added the comment: I have added a patch to update this with conditional compilation. -- keywords: +patch nosy: +ll Added file: http://bugs.python.org/file38934/CAN_RAW_FD_FRAMES.patch ___ Python tracker

[issue22631] Feature Request CAN_RAW_FD_FRAMES

Changes by Stefan Tatschner : -- title: Feature Request CAN_RAW_FD_FRAME -> Feature Request CAN_RAW_FD_FRAMES ___ Python tracker ___ _