[issue22579] Posix module init function name should not be compiler-dependent

2014-10-09 Thread STINNER Victor
STINNER Victor added the comment: Ok, I pushed the change: --- changeset: 92900:c7adad17f663 user:Victor Stinner date:Fri Oct 10 00:09:47 2014 +0200 files: Modules/posixmodule.c Closes #22579: Fix posixmodule.c to support any C compiler on Windows --- Oh, I forgot to me

[issue22579] Posix module init function name should not be compiler-dependent

2014-10-09 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue22579] Posix module init function name should not be compiler-dependent

2014-10-09 Thread STINNER Victor
STINNER Victor added the comment: > I would remove the "|| defined(__BORLANDC__) || defined(__WATCOMC__) || > defined(__DJGPP__)" part, since it's probably for MSDOS variants of those > compilers. I agree, but IMO it is unrelated to this issue. Jeffrey wants to support a new C compiler (OpenW

[issue22579] Posix module init function name should not be compiler-dependent

2014-10-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: I would remove the "|| defined(__BORLANDC__) || defined(__WATCOMC__) || defined(__DJGPP__)" part, since it's probably for MSDOS variants of those compilers. -- ___ Python tracker

[issue22579] Posix module init function name should not be compiler-dependent

2014-10-09 Thread Georg Brandl
Georg Brandl added the comment: There is also #if !defined(__QNX__) #if defined(MS_WINDOWS) || defined(__BORLANDC__) || defined(__WATCOMC__) || defined(__DJGPP__) #define SEP L'\\' #define ALTSEP L'/' #define MAXPATHLEN 256 #define DELIM L';' #endif #endif in Include/osdefs.h -- nosy:

[issue22579] Posix module init function name should not be compiler-dependent

2014-10-09 Thread STINNER Victor
STINNER Victor added the comment: The patch looks good to me, but I would prefer that someone else double check. -- components: +Windows nosy: +haypo, loewis, pitrou versions: +Python 3.5 -Python 3.4 ___ Python tracker

[issue22579] Posix module init function name should not be compiler-dependent

2014-10-08 Thread Jeffrey Armstrong
New submission from Jeffrey Armstrong: The determination of the name of the posix module's initialization function (at Modules/posixmodule.c:12055) is currently dependent on the compiler being used. For MSVC, Watcom, or Borland, the name is defined as "PyInit_nt." However, both Open Watcom