[issue21990] saxutils defines an inner class where a normal one would do

Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21990] saxutils defines an inner class where a normal one would do

Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue21990] saxutils defines an inner class where a normal one would do

Roundup Robot added the comment: New changeset a5cb10f2dbaa by Raymond Hettinger in branch '2.7': Issue #21990: Cleanup unnecessary inner class definition in saxutils. http://hg.python.org/cpython/rev/a5cb10f2dbaa -- nosy: +python-dev ___ Python trac

[issue21990] saxutils defines an inner class where a normal one would do

Changes by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue21990] saxutils defines an inner class where a normal one would do

Serhiy Storchaka added the comment: LGTM. But it would be better to add underscore prefix to class name. -- nosy: +serhiy.storchaka stage: -> commit review ___ Python tracker __

[issue21990] saxutils defines an inner class where a normal one would do

Eric V. Smith added the comment: Looks fine to me. Normally I'd define the class being returned before the function returning it, but it doesn't really make a difference. -- nosy: +eric.smith ___ Python tracker __

[issue21990] saxutils defines an inner class where a normal one would do

Changes by Alex Gaynor : -- keywords: +needs review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue21990] saxutils defines an inner class where a normal one would do

Changes by Ned Deily : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue21990] saxutils defines an inner class where a normal one would do

New submission from Alex Gaynor: This makes things slower than they need to be (yes, even on CPython :-)), and is slightly confusing since usually inner classes are only used when a closure is needed. Attached patch simply moves the class definition. -- components: Library (Lib) files