[issue21668] The select and time modules uses libm functions without linking against it

Roundup Robot added the comment: New changeset 7530caa5ed1a by Victor Stinner in branch 'default': Issue #21668: Add also Chi Hsuan Yen to Misc/ACKS https://hg.python.org/cpython/rev/7530caa5ed1a -- ___ Python tracker

[issue21668] The select and time modules uses libm functions without linking against it

STINNER Victor added the comment: > Xavier de Gaye: "The patch should be acknowledged in Misc/NEWS to Chi Hsuan > Yen and not to me." Oh sorry. I see 4 authors in attached patches, I picked the latest. Thank you to all authors for your contribution on this issue ;-) I fixed the author in Misc

[issue21668] The select and time modules uses libm functions without linking against it

Roundup Robot added the comment: New changeset f76753f26982 by Victor Stinner in branch 'default': Issue #21668: Fix author of the patch. https://hg.python.org/cpython/rev/f76753f26982 -- ___ Python tracker ___

[issue21668] The select and time modules uses libm functions without linking against it

Xavier de Gaye added the comment: The patch should be acknowledged in Misc/NEWS to Chi Hsuan Yen and not to me. -- ___ Python tracker ___

[issue21668] The select and time modules uses libm functions without linking against it

STINNER Victor added the comment: I pushed ext_modules_libm.patch with the helper function proposed by Chi Hsuan Yen in https://github.com/yan12125/python3-android/blob/038271d/mk/python/modules-link-libm.patch. Tell me if it's not enough. I hope that it will make CPython a little bit more po

[issue21668] The select and time modules uses libm functions without linking against it

Roundup Robot added the comment: New changeset f92fea23161d by Victor Stinner in branch '3.5': setup.py: add missing libm dependency https://hg.python.org/cpython/rev/f92fea23161d New changeset 3a9b47b062b9 by Victor Stinner in branch 'default': Merge 3.5: Issue #21668 https://hg.python.org/cpyt

[issue21668] The select and time modules uses libm functions without linking against it

Chi Hsuan Yen added the comment: The approach with a helper function is better. See https://github.com/yan12125/python3-android/blob/038271d/mk/python/modules-link-libm.patch. By the way, I have verified there are no libraries referencing libm functions with https://github.com/yan12125/python

[issue21668] The select and time modules uses libm functions without linking against it

Xavier de Gaye added the comment: The _datetime module also calls functions in libm: delta_new() uses round() and accum() uses modf(). The attached patch updates setup.py for all the modules that use libm. -- nosy: +xdegaye Added file: http://bugs.python.org/file42514/ext_modules_libm.p

[issue21668] The select and time modules uses libm functions without linking against it

Chi Hsuan Yen added the comment: Well, the hg revision of Python in two tests are different, because I `hg pull -u` each time I build. -- ___ Python tracker ___

[issue21668] The select and time modules uses libm functions without linking against it

Chi Hsuan Yen added the comment: Bump. For rev c6930661599b timemodule.c and selectmodule.c no longer calls libm functions, while audioop.c and _ctypes_test.c still do. I have my updated patch here based on previous patches. Note that the introduction of detect_math_libs() is my naive try. Its

[issue21668] The select and time modules uses libm functions without linking against it

Matt Frank added the comment: >> audioop_ctypes_test_link_with_libm.patch > + libraries=['m']) > Why not using math_libs here? math_libs is defined in detect_modules(). But the _ctypes_test extension is defined in a different function: detect_ctypes(). The other o

[issue21668] The select and time modules uses libm functions without linking against it

STINNER Victor added the comment: > audioop_ctypes_test_link_with_libm.patch + libraries=['m']) Why not using math_libs here? It would also be nice to add a comment explaining why libm is needed in each module. Can someone please combine both patches? --

[issue21668] The select and time modules uses libm functions without linking against it

Changes by Matt Frank : -- nosy: +freakboy3742 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue21668] The select and time modules uses libm functions without linking against it

Matt Frank added the comment: Additionally, * audioop calls floor() * _ctypes_test calls sqrt() Patch attached. -- ___ Python tracker ___ __

[issue21668] The select and time modules uses libm functions without linking against it

Changes by Matt Frank : -- nosy: +WanderingLogic Added file: http://bugs.python.org/file37041/audioop_ctypes_test_link_with_libm.patch ___ Python tracker ___ ___

[issue21668] The select and time modules uses libm functions without linking against it

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue21668] The select and time modules uses libm functions without linking against it

Fredrik Fornwall added the comment: Note: This causes problems at least when running on android, where the system is unable to find the symbols when loading the modules at runtime. -- ___ Python tracker __

[issue21668] The select and time modules uses libm functions without linking against it

New submission from Fredrik Fornwall: The select and time modules use functions from libm, but do not link against it. * selectmodule.c calls ceil(3) in pyepoll_poll() * timemodule.c calls fmod(3) and floor(3) in floatsleep() -- components: Build, Cross-Build files: time_and_select_modu