[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Sorry about that!! Thanks for letting me know. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: Lita, when replying by email, please, please delete the message you are replying to (except possibly for a directly quoted line or two). -- ___ Python tracker

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Sweet! Thank you so much, Terry! On Wednesday, July 23, 2014, Terry J. Reedy wrote: > > Terry J. Reedy added the comment: > > No, I believe this is done ;-). Onward to font sizing. > Thank you for the hard work on this. It is a great improvement. > > -- > re

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: No, I believe this is done ;-). Onward to font sizing. Thank you for the hard work on this. It is a great improvement. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracke

[issue21597] Allow turtledemo code pane to get wider.

Roundup Robot added the comment: New changeset 60301b9982b2 by Terry Jan Reedy in branch '2.7': Issue #21597: Turtledemo text pane can now be widened to view or copy complete http://hg.python.org/cpython/rev/60301b9982b2 New changeset 0fb515063324 by Terry Jan Reedy in branch '3.4': Issue #21597

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Just to clarify, should I submit a new patch with outlined style changes? -- ___ Python tracker ___ ___ Py

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: On Tue, Jul 22, 2014 at 8:20 PM, Terry J. Reedy wrote: > > Terry J. Reedy added the comment: > > I reviewed code and made the following changes in uploaded file: > Move some code and blank lines around. > Since you left packing within mBar frame, removed >sel

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: I reviewed code and made the following changes in uploaded file: Move some code and blank lines around. Since you left packing within mBar frame, removed self.mBar.grid_columnconfigure(0, weight=1) Since the only thing packed in the left frame was the text

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: For me, FLAT is about as mushy as the default, while SOLID actually looks like a divider. I find the sash easier to 'grab' and move. I plan to go with that. If it looks substantially worse on some other system, we could make the argument conditional on sys.pla

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Ping! Just wanted to see what the status was on getting this patch reviewed. I hope your eye is feeling better, Terry! -- ___ Python tracker ___

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: I personally like the FLAT look because it matches with the rest of the GUI. -- ___ Python tracker ___ ___

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Hi Terry, So the shadow can easily be removed. I just went with the default sashrelief style. I am going to attach two patches with different sashrelief styles, both of which don't have the shadow. -- Added file: http://bugs.python.org/file35889/turtledemo_

[issue21597] Allow turtledemo code pane to get wider.

Changes by Lita Cho : Added file: http://bugs.python.org/file35890/turtledemo_pane_scroll_SOLID.patch ___ Python tracker ___ ___ Python-bugs-l

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: I don't really know what most beginners will expect. Perhaps an entry in the help will be enough. I would like have a better how to use summary at the top of the file anyway. If I swish the normal cursor across the divide, it jumps from I-bar on text side to

[issue21597] Allow turtledemo code pane to get wider.

Ned Deily added the comment: > The one thing I think this patch still needs is a notice to the user that the > sash can be moved. Once place is one of the help files. I can do that. Can we > also put a line in the text box on startup? > "Change text pane width by moving the divider ==>" Is tha

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: Great improvement. Full screen on my system, the artifact ghosting band is about 1/4 inch, as with the empty panes, instead of several inches, as it was in the original patch moving right to left. This worst-case (Windows) behavior is good enough to commit whe

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: I think I have a fix!! I made it so that centering works while fixing the tearing. For some reason, in the Turtle API, the adjustScrolls method creates a new scroll widget for x and y and deletes the old one. I am not sure why it does it this way. I'm sure th

[issue21597] Allow turtledemo code pane to get wider.

Ned Deily added the comment: Lita, turtledemo_pane_srcoll_fix.patch definitely solves the "tearing" problems (when viewed with OS X Cocoa and X11 Tk's): yay! Good luck with getting the centering working! -- ___ Python tracker

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: ?! After debugging for awhile, I got it so that PanedWindow doesn't cause the rightmost widget to tear! I had to disable the resizing binding on Turtle to make it work. However, now it seems like the canvas is no longer centered. Is there anyway for me to get arou

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: I also put this patch out there. This doesn't have the PaneWindow, but I manually widen the text pane. This would be the compromise if I can't figure out the tearing due to the sash moving. -- Added file: http://bugs.python.org/file35874/turtledemo_grid.patc

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Hey Terry, So the reason why the tearing is a lot slower in 06/09 patch is because the canvas is using the turtle.ScrolledCanvas widget. Everytime the window resizes, it is calling a callback to `onResize` -> `adjustScrolls` to update the scrollbars. When I comment

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: "Windows Media Player cannot play the file. The Player might not support the file type or might not support the codec that was used to compress the file." However, Ned's description matches what I see, including the detail about a frame being momentarily being

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: 'under Idle' here means in a separate process with its own tk loop. I tried from the cmd line and see the same. My 3-yr-old machine has what was then a top-of-the-line Pentium. Also, as I said, the test code works much better than the 6/09 patch with widgets i

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Yes! This is the first version of the code without using ttk widgetd. Using Labels instead of buttons. -- ___ Python tracker ___

[issue21597] Allow turtledemo code pane to get wider.

Ned Deily added the comment: Lita, the movie looks comparable to what I'm seeing but without the background colors and with thin-lined black border rectangles around each of the two frames. -- ___ Python tracker

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Hm, when I upgrade to 8.6, I still get the tearing action on the very right of the window. Although, again, it doesn't seem that bad. I've attahed what I am seeing, just to confirm we are all talking about the same thing. -- Added file: http://bugs.python.or

[issue21597] Allow turtledemo code pane to get wider.

Ned Deily added the comment: Lita, testing the second turtledemo_pane.patch (2014-06-09) with a current default (pre-3.5) build and with OS X ActiveTcl 8.5.15: if an example is selected but not running, moving the slider to the left is fairly smooth but the scroll bar for the right frame tends

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Oh man, I was running version '8.5.9' using 'aqua'. I am going to try and upgrade and see if the artifacting goes away. Lita -- ___ Python tracker _

[issue21597] Allow turtledemo code pane to get wider.

Ned Deily added the comment: Lita, to find the detailed Tk version info (which is really important with 8.5 since it has changed considerably over its long life): >>> import tkinter >>> t = tk.Tk() >>> t.tk.call('info', 'patchlevel') '8.5.15' >>> t.tk.call('tk', 'windowingsystem') 'aqua' http:

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: If we can use the weighted ttk paned window, so sash movement is only used when really needed (small windows) then it would be ok. (I would add a note in one of the help texts -- "On some systems, there are visual artifacts when enlarging the window or moving

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: >>> TkVersion 8.6 which is not helpful if you want to know which 8.5 version on Mac. -- ___ Python tracker ___ _

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: I feel like the PaneWindow is nice. I could also see down the road making the code text bigger. However, if on Windows, the artifacting is really bad, I can totally switch this back to the grid view. -- ___ Python tracke

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: Stuttering might be a better term. For the initial small window, I did not see much difference between 2.7 and 3.4. At full screen on a 25xx x 14xx screen, both stuttered. If the 2.7 looked better, it is because it redrew slower. If I zipped the mouse fast e

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Oh I had no idea! That makes sense. How do I know which version of Tk I'm working with? I'm testing on Mac OSX as well! Would there be anyway for you to test my patch for turtledemo to see if the sash causes artifacting for you? I see tearing but it snap back into p

[issue21597] Allow turtledemo code pane to get wider.

Ned Deily added the comment: If by tearing you mean leaving artifacts on the screen, differences in behavior are almost certainly due to different versions of Tk being used. Tkinter is really just a wrapper around calls to Tk; nearly all of the heavy-duty graphics work is done by Tk making ca

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Should I file a bug? I feel like this a bug specifically related to Python 3 and Tkinter. -- ___ Python tracker ___ _

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Hi Terry, I started digging into this deeper and it looks like my tests doesn't tear in Python 2.7. I have tried on Python 3.5 and 3.4 and it tears on those versions. I also tried the ttk objects, and the widgets also teared when I added frames. Here is the code I

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: I played around for a couple of hours, but am not sure what I want to do other than catching currently uncaught turtle.Terminator (in another issue). I might want to try my original idea of just using grid, without PanedWindow. Another idea is to ttk widgets,

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: I downloaded new patch and will try to look at it this weekend. -- ___ Python tracker ___ ___ Python

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: ping! I just want to know how I should proceed with this ticket. I can try removing the Frames with get rid of the lag, but then I feel like we can't use the Grid Manager at all. :\ -- ___ Python tracker

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: > 1. The minor one: The blue label does not have drop shadows, the red/yellow > buttons do. I created a patch to add a border around the label and create some padding between the buttons and the label. Let me know if this is less jarring than the previous version.

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Hi Terry! > 2. More important: when I move the slider right, the text widen and the > canvas narrows relatively smoothly. This is not due to the mixing of Pack and Grid Managers. This is due to adding Frames within a Pane Window. If I just create two empty Pane Wi

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: I ran the patched code but have not looked at the code itself. Pending such a look, I would consider committing it if we cannot do better, as it solves both issues. However, there are two visual issues. 1. The minor one: The blue label does not have drop shado

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: Hi Terry! I went ahead and added a movable divider (also known as a "sash") using the PanedWindow widget. http://effbot.org/tkinterbook/panedwindow.htm#reference I also converted the master window to use a grid geometry manager. It looks like you can use pack manag

[issue21597] Allow turtledemo code pane to get wider.

Terry J. Reedy added the comment: The patch for #18132 replaced pack with grid, But the replacement seemed partial even within the top frame (but I may have misread). Mixing the two is known to be a bad idea. http://effbot.org/tkinterbook/grid.htm has a big warning box about this. I think we c

[issue21597] Allow turtledemo code pane to get wider.

Lita Cho added the comment: I'll take this on. -- nosy: +Lita.Cho ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue21597] Allow turtledemo code pane to get wider.

Changes by Lita Cho : -- nosy: +jesstess ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue21597] Allow turtledemo code pane to get wider.

New submission from Terry J. Reedy: Turtledemo (python -m turtledemo) has a text pane for code and a canvas pane for the actual demo. The code pane is fixed at about 60% of the width needed to display full-width code lines. If the window is expanded horizontally, all the expansion goes to the