[issue21519] IDLE : Bug in keybinding validity check

Terry J. Reedy added the comment: Thanks for the patch. The F3-missing bug has been fixed. -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker

[issue21519] IDLE : Bug in keybinding validity check

Terry J. Reedy added the comment: New changeset 93b88e995373c48713c9f7d4b32fe1d0166709e5 by terryjreedy in branch '3.6': [3.6] bpo-21519: IDLE basic custom key entry better detects duplicates. (GH-2428) (#2433) https://github.com/python/cpython/commit/93b88e995373c48713c9f7d4b32fe1d0166709e5

[issue21519] IDLE : Bug in keybinding validity check

Changes by Terry J. Reedy : -- pull_requests: +2481 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue21519] IDLE : Bug in keybinding validity check

Terry J. Reedy added the comment: New changeset 44913e584bcf4e2a0e1a6372c304c2d5ea521fc6 by terryjreedy in branch 'master': bpo-21519: IDLE basic custom key entry better detects duplicates. (#2428) https://github.com/python/cpython/commit/44913e584bcf4e2a0e1a6372c304c2d5ea521fc6 -- _

[issue21519] IDLE : Bug in keybinding validity check

Changes by Terry J. Reedy : -- pull_requests: +2479 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue21519] IDLE : Bug in keybinding validity check

Terry J. Reedy added the comment: configdialog.ConfigDialog.getNewKeys() calls config_key.GetKeysDialog with a list of lists of one or more sequences (currentKeySequences). GetKeysDialog.KeysOK looks for keys.split() in currentKeySequences. Since KeysOK on only called for the no-space 'keys'

[issue21519] IDLE : Bug in keybinding validity check

Terry J. Reedy added the comment: #6739 is about rejecting *invalid* sequences, this is about rejecting a *duplicate* valid sequence. Both fixes are needed. -- ___ Python tracker _

[issue21519] IDLE : Bug in keybinding validity check

Terry J. Reedy added the comment: I believe patch affects same area of file as patch for #6739. -- ___ Python tracker ___ ___ Python-b

[issue21519] IDLE : Bug in keybinding validity check

Terry J. Reedy added the comment: #6739 also has a patch to refuse invalid key bindings. -- assignee: -> terry.reedy versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4 ___ Python tracker ___

[issue21519] IDLE : Bug in keybinding validity check

Terry J. Reedy added the comment: #6739 may also be relevant -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21519] IDLE : Bug in keybinding validity check

Saimadhav Heblikar added the comment: A small bug in line 185 in keybindingDialog.py. 'F2' appears twice and 'F3' is missing. Since this is a typo, I did not create a new issue. -- ___ Python tracker _

[issue21519] IDLE : Bug in keybinding validity check

Terry J. Reedy added the comment: > Now the binding will be assigned to two actions. I do not see this. I only see duplicated, which is bad enough to be patched. What did you leave out ;-). Also see #12387, which we need to finish, and Ned's link to http://wiki.tcl.tk/28331 A patch for K

[issue21519] IDLE : Bug in keybinding validity check

New submission from Saimadhav Heblikar: Steps to reproduce the bug: 1. IDLE > options > configure idle > keys 2. Try to replace a keybinding for an action with that of another action which has more than one keybinding. For eg : Default binding of copy= . So, try to replace any other keybinding