[issue21503] Use test_both() consistently throughout test_importlib

Changes by Eric Snow : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ ___ Pytho

[issue21503] Use test_both() consistently throughout test_importlib

Roundup Robot added the comment: New changeset 34d65746d5ca by Eric Snow in branch 'default': Issue #21503: Use test_both() consistently in test_importlib. http://hg.python.org/cpython/rev/34d65746d5ca -- nosy: +python-dev ___ Python tracker

[issue21503] Use test_both() consistently throughout test_importlib

Eric Snow added the comment: FWIW, this change was motivated by the importlib backport (I found some time to work on it). The import_importlib()/test_both() approach definitely makes backporting the tests easier (thanks for that). BTW, thanks for also consolidating the various test_importlib

[issue21503] Use test_both() consistently throughout test_importlib

Eric Snow added the comment: > I don't love the formatting of the test_both() lines, but I think that one is > just an aesthetic thing that will never make people happy -- weird line > wrapping or really long lines -- so just leave it as-is in your patch. Yeah, I went with the formatting that

[issue21503] Use test_both() consistently throughout test_importlib

Brett Cannon added the comment: I see you noticed my shift in strategy after I realized part way through a cleaner way of doing things. =) LGTM I don't love the formatting of the test_both() lines, but I think that one is just an aesthetic thing that will never make people happy -- weird line

[issue21503] Use test_both() consistently throughout test_importlib

New submission from Eric Snow: test_importlib.util provides the test_both() function that facilitates testing both the frozen and source versions of importlib. The function helps to keep the tests more maintainable. However, the following test modules are not using test_both(): Lib/test/tes