[issue21463] RuntimeError when URLopener.ftpcache is full

Skyler Leigh Amador added the comment: You're welcome, happy to help :) On Mon, Jun 9, 2014 at 8:31 AM, Erik Bray wrote: > > Erik Bray added the comment: > > Thanks Skyler for finishing the job. I got busy/distracted. > > -- > > ___ > Python tracker

[issue21463] RuntimeError when URLopener.ftpcache is full

Erik Bray added the comment: Thanks Skyler for finishing the job. I got busy/distracted. -- ___ Python tracker ___ ___ Python-bugs-li

[issue21463] RuntimeError when URLopener.ftpcache is full

Roundup Robot added the comment: New changeset b8f9ae84d211 by Benjamin Peterson in branch '3.4': in ftp cache pruning, avoid changing the size of a dict while iterating over it (closes #21463) http://hg.python.org/cpython/rev/b8f9ae84d211 New changeset 6f70a18313e5 by Benjamin Peterson in bran

[issue21463] RuntimeError when URLopener.ftpcache is full

Skyler Leigh Amador added the comment: Addressed review comments -- Added file: http://bugs.python.org/file35529/urllib-request-ftpcache-test.patch ___ Python tracker ___ ___

[issue21463] RuntimeError when URLopener.ftpcache is full

Benjamin Peterson added the comment: (I left some comments on Rietveld.) -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python

[issue21463] RuntimeError when URLopener.ftpcache is full

Skyler Leigh Amador added the comment: I've made a test for this patch with a very minimal mock ftpwrapper. We can see it fails on dictionary size change without Erik's fix: == ERROR: test_ftp_cache_pruning (test.test_urllib.ur

[issue21463] RuntimeError when URLopener.ftpcache is full

Jessica McKellar added the comment: I want to state explicitly what the error is for some new contributors who might pick this up at a sprint this weekend: The issue is that you can't change a dictionary while iterating over it: >>> d = {"a": "b"} >>> for elt in d.keys(): ... del d[elt] ..

[issue21463] RuntimeError when URLopener.ftpcache is full

Erik Bray added the comment: Ah, didn't know that about "crash". I wanted to add a test but hesitated only because that code is not well tested to begin with (perhaps, hence, this going unnoticed for so long). But I guess it could be done by mocking the ftpwrapper class. --

[issue21463] RuntimeError when URLopener.ftpcache is full

Éric Araujo added the comment: Thanks for the report and patch. Would you mind adding a unit test? (Note that the “crash” type is for segfaults, not Python exceptions.) -- nosy: +eric.araujo stage: -> test needed type: crash -> behavior versions: +Python 2.7, Python 3.4, Python 3.5 _

[issue21463] RuntimeError when URLopener.ftpcache is full

Changes by Berker Peksag : -- nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue21463] RuntimeError when URLopener.ftpcache is full

New submission from Erik Bray: This is probably a pretty rare corner case, but a coworker reported this to me while testing code that does open several ftp connections to different files. -- components: Library (Lib) files: urllib-request-ftpcache-error.patch keywords: patch messages: 2