[issue21312] Update thread_foobar.h to include timed locking and TLS support

Roundup Robot added the comment: New changeset 7bb1bda5dcef by Antoine Pitrou in branch 'default': Issue #21312: Update the thread_foobar.h template file to include newer threading APIs. Patch by Jack McCracken. http://hg.python.org/cpython/rev/7bb1bda5dcef -- nosy: +python-dev __

[issue21312] Update thread_foobar.h to include timed locking and TLS support

Antoine Pitrou added the comment: Ok, noone chimed in, so I committed the patch :-) Thank you very much for your contribution! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue21312] Update thread_foobar.h to include timed locking and TLS support

Antoine Pitrou added the comment: Thanks! The patch looks good to me, I'll let it sleep a bit to see if other people have an opinion. -- nosy: +tim.peters stage: -> patch review versions: +Python 3.5 ___ Python tracker

[issue21312] Update thread_foobar.h to include timed locking and TLS support

Jack McCracken added the comment: Oops... I removed that and just put the deferral in there. -- Added file: http://bugs.python.org/file34977/update_thread_foobar_v4.diff ___ Python tracker _

[issue21312] Update thread_foobar.h to include timed locking and TLS support

Antoine Pitrou added the comment: Hum, your comment about deferring is wrong, since thread_nt.h also does the deferring: int PyThread_acquire_lock(PyThread_type_lock aLock, int waitflag) { return PyThread_acquire_lock_timed(aLock, waitflag ? -1 : 0, 0); } -- __

[issue21312] Update thread_foobar.h to include timed locking and TLS support

Jack McCracken added the comment: Added an example of deferring to PyThread_acquire_lock_timed in PyThread_acquire_lock. Also fixed a mistake in the string of a dprintf in PyThread_acquire_lock_timed. -- Added file: http://bugs.python.org/file34976/update_thread_foobar_v3.diff ___

[issue21312] Update thread_foobar.h to include timed locking and TLS support

Antoine Pitrou added the comment: You may want to provide an implementation of PyThread_acquire_lock() that simply defers to PyThread_acquire_lock_timed() (see thread_pthread.h, which does the same). -- nosy: +pitrou ___ Python tracker

[issue21312] Update thread_foobar.h to include timed locking and TLS support

Jack McCracken added the comment: Missed a word in a comment -- Added file: http://bugs.python.org/file34975/update_thread_foobar_v2.diff ___ Python tracker ___ _

[issue21312] Update thread_foobar.h to include timed locking and TLS support

New submission from Jack McCracken: The thread_foobar.h reference for the interface for abstracting the platform-specific thread implementation does not include newer features such as timed locking and TLS support. -- components: Interpreter Core files: update_thread_foobar.diff keywor