[issue20887] stdlib compatibility with pypy, test_zipfile.py

Benjamin Peterson added the comment: Thanks for the patch. 3.x test_zipfile can be dealt with elsewhere if desired. -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker __

[issue20887] stdlib compatibility with pypy, test_zipfile.py

Roundup Robot added the comment: New changeset 03df2c1c6892 by Benjamin Peterson in branch '2.7': properly close files in test_zipfile (#20887) http://hg.python.org/cpython/rev/03df2c1c6892 -- nosy: +python-dev ___ Python tracker

[issue20887] stdlib compatibility with pypy, test_zipfile.py

Arfrever Frehtes Taifersar Arahesis added the comment: Garbage collection still closes files, but Python >=3.2 might print ResourceWarnings. -- nosy: +Arfrever ___ Python tracker __

[issue20887] stdlib compatibility with pypy, test_zipfile.py

mattip added the comment: As far as I know, cpython3 dropped the assumption that garbage collection closes files, so python3's version of this test should already handle the issue, no? -- ___ Python tracker _

[issue20887] stdlib compatibility with pypy, test_zipfile.py

Éric Araujo added the comment: If you want to provide two patches for the two major lines, that’d be ideal. Please post both on this one ticket though. Thank you! -- nosy: +eric.araujo ___ Python tracker ___

[issue20887] stdlib compatibility with pypy, test_zipfile.py

mattip added the comment: The test_zipfile in Python 3 is very different from this one, so I would prefer that it be two seperate issues. After your review of the patch, are there remaining issues that need to be cleared up? -- ___ Python tracker

[issue20887] stdlib compatibility with pypy, test_zipfile.py

Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue20887] stdlib compatibility with pypy, test_zipfile.py

Serhiy Storchaka added the comment: In general LGTM. Do you interesting in porting this to Python 3 (this would be non-trivial work)? -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka stage: -> needs patch versions: +Python 3.3, Python 3.4 _

[issue20887] stdlib compatibility with pypy, test_zipfile.py

Changes by Brian Kearns : -- nosy: +bdkearns ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue20887] stdlib compatibility with pypy, test_zipfile.py

New submission from mattip: Files must be explicitly closed on pypy, and switch to use test_support.rmtree which tries harder on Windows. only test_zipfile.py is patched. -- components: Tests files: zipfile_patch messages: 213086 nosy: mattip priority: normal severity: normal status: o