[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Change by Irit Katriel : -- stage: patch review -> resolved status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list ma

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Terry J. Reedy added the comment: 'Pending' is pretty useless because any comment erases it. This is a tracker bug that will not be fixed. -- status: open -> pending ___ Python tracker

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Terry J. Reedy added the comment: I reread the patch and my previous comment and am no more positive than I was then. The one use case presented is second-hand. Chris said "in order for [Bazaar] to use a custom sequence matcher, they had to essentially copy-paste and modify the stdlib diff

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Irit Katriel added the comment: I agree with Terry that this proposal significantly complicates the API and the motivation for it is not very strong. I will close the issue in a couple of weeks if nobody objects. -- nosy: +iritkatriel resolution: -> rejected status: open -> pending

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Changes by Claudiu Popa : -- nosy: -Claudiu.Popa ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Terry J. Reedy added the comment: Current status: Tim is currently not actively involved in Python development and no one who is active is enthusiastic about the proposal. Your proposal is to add dependency injection to the initializer for the 4 diff classes by adding 6 new parameters. I will

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Chris Rose added the comment: What's the word on this change? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Changes by Claudiu Popa : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Chris Rose added the comment: As suggested: SYN -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

R. David Murray added the comment: Well, it would be 3.5, so there's plenty of time yet. We are hoping for an answer from Tim Peters, but if we don't get one someone else will review it as time allows. Pinging the issue like this was good; do it again in another month if there's no further a

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Chris Rose added the comment: Ping? I'd like to know if the proposed solution passes muster, so that I can get this into ... well, whatever the right revision would be. -- ___ Python tracker __

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Changes by Chris Rose : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Chris Rose added the comment: As a historical record, it should be noted that this is driven by an actual use case: I was experimenting with using Bazaar's patience diff implementation, and I saw that in order for them to use a custom sequence matcher, they had to essentially copy-paste and mo

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Chris Rose added the comment: Patch against tip -- Added file: http://bugs.python.org/file34871/difflib-sm.patch ___ Python tracker ___ __

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Chris Rose added the comment: Addressed comments regarding documentation and assertion formats in the test. -- Added file: http://bugs.python.org/file34869/difflib-sm.patch ___ Python tracker __

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Claudiu.Popa added the comment: Hi. I added a couple of comments for your previous patch, the new one doesn't seem to have a review link. -- nosy: +Claudiu.Popa ___ Python tracker _

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Chris Rose added the comment: Updated according to review. -- Added file: http://bugs.python.org/file34868/difflib-sm.patch ___ Python tracker ___ ___

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Raymond Hettinger added the comment: Uncle Timmy, what say you? -- assignee: -> tim.peters nosy: +rhettinger, tim.peters ___ Python tracker ___ _

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

Chris Rose added the comment: I've regenerated the patch with doc additions and Misc/ACKS changed as well. -- Added file: http://bugs.python.org/file34204/difflib-sm.patch ___ Python tracker ___

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

New submission from Chris Rose: It should be possible to provide subclasses or implementations of the SequenceMatcher interface to difflib's various methods that do formatting (for example, unified_diff/context_diff et al). I've included a patch for it that satisfies my personal itch on the su