[issue20628] csv.DictReader

Changes by Sean Rodman : Removed file: http://bugs.python.org/file34141/DictReader_DictWriter_python2_NewWording.patch ___ Python tracker ___ ___

[issue20628] csv.DictReader

Sean Rodman added the comment: Great! Thank you for the reference name. I have changed the patch to use a ref link. Here is the new patch. -- Added file: http://bugs.python.org/file34155/DictReader_DictWriter_python2_ref.patch ___ Python tracker

[issue20628] csv.DictReader

R. David Murray added the comment: I figured out what you meant, but thanks for the clarification. The section of interest in 2.7 is near the bottom of the page you linked to. It already has a Sphinx section reference (collections-abstract-base-classes), so you can use :ref: to link to it. -

[issue20628] csv.DictReader

Sean Rodman added the comment: I just realized that my two last updates on this ticket could be sort of confusing. So here is what I did for the 2.7 patch. First I copied the wording that I used for the 3.3/4 patch and then I created a relative link using the syntax `sequence `_ because I coul

[issue20628] csv.DictReader

Sean Rodman added the comment: That is supposed to say I couldn't find the subsection that I needed to reference in the documentation. -- ___ Python tracker ___

[issue20628] csv.DictReader

Sean Rodman added the comment: Here is the equivalent 2.7 patch. I used a relative link with the format `sequence `_ in order to link to the collections page. I tried to use the reference syntax but I could find the subsection that I needed to reference in the documentation. If you would like

[issue20628] csv.DictReader

R. David Murray added the comment: Yes, that does sound better. If you can make an equivalent 2.7 patch I will apply them. -- versions: +Python 3.3 ___ Python tracker ___ _

[issue20628] csv.DictReader

Changes by Sean Rodman : Removed file: http://bugs.python.org/file34136/DictReader_DictWriter_python3.patch ___ Python tracker ___ ___ Python

[issue20628] csv.DictReader

Sean Rodman added the comment: What about if I put "The *fieldnames* parameter is a :mod:`sequence ` whose elements are associated with the fields of the input data in order. These elements become the keys of the resulting dictionary." It contains all of the information that you have but it fe

[issue20628] csv.DictReader

R. David Murray added the comment: This looks pretty good. In the DictReader part, it might be good to add something analogous to the DictWriter clarifying what the order of the sequence means. Something like "a :mod:`sequence ` whose elements are associated with the fields of the input data

[issue20628] csv.DictReader

Sean Rodman added the comment: Ok, I have take the approach I used with the original patch and applied it to this one, listing that fieldnames is a sequence. Then, I added a link to the collections abstract on that instance of the word sequence. I did this for both DictReader and DictWriter as

[issue20628] csv.DictReader

Changes by Sean Rodman : Removed file: http://bugs.python.org/file34135/DictReader_python3.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue20628] csv.DictReader

Changes by Sean Rodman : Removed file: http://bugs.python.org/file34109/DictReader_DictWriter_2.patch ___ Python tracker ___ ___ Python-bugs-l

[issue20628] csv.DictReader

R. David Murray added the comment: I'd like to combine the two approaches: mention that fieldnames is a sequence (with the link) as soon as fieldnames is introduced in the paragraph, analogous to what you did in the first patch. Whether you then make what becomes the second occurrence of the

[issue20628] csv.DictReader

Sean Rodman added the comment: Here is a patch for DictReader that adds a mod link to the sequence abstract as requested. Please review this if you could and let me know what you think. Note: This patch is for python 3 and if you like how I have done it on here I will go ahead and create a pat

[issue20628] csv.DictReader

R. David Murray added the comment: Well, there is a reason why the term 'sequence' was used. It covers lists, tuples...and anything else that implements the Sequence ABC (http://docs.python.org/library/collections.html#collections-abstract-base-classes). The word 'sequence' could be made a li

[issue20628] csv.DictReader

Changes by Sean Rodman : Removed file: http://bugs.python.org/file34084/DictReader_DictWriter.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue20628] csv.DictReader

Sean Rodman added the comment: It looks like you are right. I have updated the patch to reflect that it could be a list or a tuple. -- Added file: http://bugs.python.org/file34109/DictReader_DictWriter_2.patch ___ Python tracker

[issue20628] csv.DictReader

Roger Erens added the comment: I did not fully realize the meaning of it being a sequence as it is referred to a little later indeed. Which implies both a tuple and a list can be used, right? So then the patch might look like: + The *fieldnames* parameter is a list or tuple of keys used for

[issue20628] csv.DictReader

Sean Rodman added the comment: I have created a patch for this documentation issue. Could you please review this for me and tell me what you think? -- keywords: +patch Added file: http://bugs.python.org/file34084/DictReader_DictWriter.patch ___ Pytho

[issue20628] csv.DictReader

Sean Rodman added the comment: I am new to contributing to python, and I would like to take a shot a creating a patch for this. -- nosy: +sean.rodman ___ Python tracker ___

[issue20628] csv.DictReader

R. David Murray added the comment: Fieldnames is referred to as a sequence, which does define its type. That said, defining the type earlier in that paragraph would probably be a good thing. -- nosy: +r.david.murray ___ Python tracker

[issue20628] csv.DictReader

New submission from Roger Erens: The sections on DictReader and DictWriter do not give information on what the type is of the parameter 'fieldnames'. The source code comments that it is a 'list of keys for the dict'. -- assignee: docs@python components: Documentation messages: 211226 n