[issue20416] Marshal: performance regression with versions 3 and 4

Serhiy Storchaka added the comment: Thanks for your review Antoine and Victor. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue20416] Marshal: performance regression with versions 3 and 4

Roundup Robot added the comment: New changeset 012364df2712 by Serhiy Storchaka in branch 'default': Issue #20416: marshal.dumps() with protocols 3 and 4 is now 40-50% faster on https://hg.python.org/cpython/rev/012364df2712 -- nosy: +python-dev ___ P

[issue20416] Marshal: performance regression with versions 3 and 4

STINNER Victor added the comment: (I didn't reproduce the benchmark, I just used Serhy numbers. I guess that using memcpy() doesn't make the code slower.) -- ___ Python tracker

[issue20416] Marshal: performance regression with versions 3 and 4

STINNER Victor added the comment: Except of the minor suggestion that I added on the review, the patch looks good the me. It's quite simple and makes dumps() 34% faster (for protocol 4). -- ___ Python tracker

[issue20416] Marshal: performance regression with versions 3 and 4

Serhiy Storchaka added the comment: Update patch addresses Victor's comments. -- Added file: http://bugs.python.org/file38088/marshal_hashtable_2.patch ___ Python tracker ___ ___

[issue20416] Marshal: performance regression with versions 3 and 4

Serhiy Storchaka added the comment: Here are new results with corrected marshalbench.py (more precise and with recalculated total size): Without the patch: ver. dumps loads size 746.5 19971.2 0 669.1 1149.2 26202.9 1 682.0 1130.1 26202.9 2 652.0 1134.8

[issue20416] Marshal: performance regression with versions 3 and 4

Antoine Pitrou added the comment: Can you post the results of your hashtable patch with marshalbench.py? PS: we don't care about versions older than 4. -- ___ Python tracker ___

[issue20416] Marshal: performance regression with versions 3 and 4

Serhiy Storchaka added the comment: What are your thoughts Victor? -- title: Marshal: special case int and float, don't use references -> Marshal: performance regression with versions 3 and 4 ___ Python tracker __