[issue20350] Replace tkapp.split() to tkapp.splitlist()

2016-06-25 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7, Python 3.5 ___ Python tracker ___ __

[issue20350] Replace tkapp.split() to tkapp.splitlist()

2016-06-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8d78cd7c4a9e by Serhiy Storchaka in branch 'default': Issue #20350. tkapp.splitlist() is now always used instead of unreliable https://hg.python.org/cpython/rev/8d78cd7c4a9e -- nosy: +python-dev ___ Pytho

[issue20350] Replace tkapp.split() to tkapp.splitlist()

2016-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: FWIW, patch applies cleanly to 3.6 on Windows and test_idle passes. -- versions: +Python 3.5, Python 3.6 -Python 3.3, Python 3.4 ___ Python tracker

[issue20350] Replace tkapp.split() to tkapp.splitlist()

2016-06-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Most methods are tested now. There is a difference between split() and splitlist() in Variable.trace_vinfo() if the tracer was assigned not by Tkinter method Variable.trace_variable(), but by direct execution of Tcl command "trace add variable" and additiona

[issue20350] Replace tkapp.split() to tkapp.splitlist()

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I use Linux. Unfortunately these methods (as most methods in Tkinter) are not tested. IDLE doesn't use any of these methods. -- ___ Python tracker __

[issue20350] Replace tkapp.split() to tkapp.splitlist()

2014-02-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: I know split has been troublesome and I am generally in favor of removing semi-duplication. Here are my questions. What system are you developing and testing on? Should I try the patch on Windows? Have you used coveragepy to see if the patched areas are covered

[issue20350] Replace tkapp.split() to tkapp.splitlist()

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If there are no objections I'll commit this patch tomorrow. -- assignee: -> serhiy.storchaka ___ Python tracker ___ _

[issue20350] Replace tkapp.split() to tkapp.splitlist()

2014-01-22 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Proposed patch replaces errorprone uses of tkapp.split() to tkapp.splitlist(). * Variable.trace_vinfo(). Actually there are no difference between split() and splitlist(), because "trace vinfo" always returns a list of 2-element tuple of strings and none of