[issue20204] pydocs fails for some C implemented classes

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue20204] pydocs fails for some C implemented classes

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue20204] pydocs fails for some C implemented classes

Roundup Robot added the comment: New changeset a192cc5a63be by Serhiy Storchaka in branch '3.4': Issue #20204: Added the __module__ attribute to _tkinter classes. https://hg.python.org/cpython/rev/a192cc5a63be New changeset 3244142eeafb by Serhiy Storchaka in branch 'default': Issue #20204: Adde

[issue20204] pydocs fails for some C implemented classes

Nick Coghlan added the comment: ImportWarning is slightly different - it's aimed at issues that happen during the operation of the import machinery itself. This isn't that - it's a warning related to the extension module actually initialising itself, so it's akin to a warning issued due to the

[issue20204] pydocs fails for some C implemented classes

Serhiy Storchaka added the comment: It also can be ImportWarning (warnings triggered during the process of importing a module (ignored by default)). -- ___ Python tracker ___ __

[issue20204] pydocs fails for some C implemented classes

Nick Coghlan added the comment: The case for RuntimeWarning: the object isn't necessarily *broken* as such (most things will still work), but pickling and some introspection features may not work properly. The case for DeprecationWarning: breaking picking and introspection is bad when the fix

[issue20204] pydocs fails for some C implemented classes

Serhiy Storchaka added the comment: What type of warning is more preferable here? It will be emitted at import. E.g.: $ ./python -Wall Python 3.5.0a1+ (default:28ba862036cc+, Feb 28 2015, 11:01:23) [GCC 4.8.2] on linux Type "help", "copyright", "credits" or "license" for more information. >>>

[issue20204] pydocs fails for some C implemented classes

Changes by Serhiy Storchaka : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue20204] pydocs fails for some C implemented classes

Serhiy Storchaka added the comment: Here is a patch which adds a warning to PyType_FromSpec and PyType_FromSpecWithBases if type spec name doesn't contain module name. In conjunction with tkinter_typespecs.patch it should fix the issue. -- stage: needs patch -> patch review Added file:

[issue20204] pydocs fails for some C implemented classes

Serhiy Storchaka added the comment: I think we should add a check to ensure than heap types have the __module__ attribute. -- assignee: -> serhiy.storchaka stage: -> needs patch ___ Python tracker __

[issue20204] pydocs fails for some C implemented classes

Serhiy Storchaka added the comment: _tkinter.TkappType.__flags__ is different. In 3.3: 0b101 In 3.4: 0b1010010 The difference is Py_TPFLAGS_HEAPTYPE. This is the consequence of the change made in issue15721. -- components: +Interpreter Core, Tkinter nosy: +

[issue20204] pydocs fails for some C implemented classes

Serhiy Storchaka added the comment: The problem not in pydoc or inspect itself. In Python 3.3 _tkinter.TkappType has the __module__ attribute: >>> import _tkinter >>> _tkinter.TkappType.__module__ 'builtins' Something was changed in 3.4 and builtin classes without dot in qualified name no lon

[issue20204] pydocs fails for some C implemented classes

Serhiy Storchaka added the comment: With issue #20372 patch pydoc no longer raise an exception, but it also doesn't produce useful output. In 3.3 it prints more details. -- ___ Python tracker _

[issue20204] pydocs fails for some C implemented classes

Yury Selivanov added the comment: See issue #20372 -- fix for the 'inspect.getfile' function. -- ___ Python tracker ___ ___ Python-bug

[issue20204] pydocs fails for some C implemented classes

Changes by Serhiy Storchaka : -- nosy: +yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue20204] pydocs fails for some C implemented classes

Changes by Antoine Pitrou : -- nosy: +brett.cannon, eric.snow, ncoghlan priority: normal -> high ___ Python tracker ___ ___ Python-bug

[issue20204] pydocs fails for some C implemented classes

New submission from Serhiy Storchaka: In 3.4 pydoc fails for the TkappType and TkttType names in the _tkinter module. $ ./python -m pydoc _tkinter.TkappType Traceback (most recent call last): File "/home/serhiy/py/cpython/Lib/runpy.py", line 189, in _run_module_as_main "__main__", mod_spec