[issue19884] Importing readline produces erroneous output

Martin Panter added the comment: I committed my patch in full, so hopefully the Gnu Readline situation on OS X is also improved. Original fixes went into 3.4, but my patch only went into 3.5+. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Py

[issue19884] Importing readline produces erroneous output

Roundup Robot added the comment: New changeset 55ec5fdc3099 by Martin Panter in branch '2.7': Issue #19884: Avoid spurious output on OS X with Gnu Readline https://hg.python.org/cpython/rev/55ec5fdc3099 New changeset 782d9b5d2e90 by Martin Panter in branch '3.5': Issue #19884: Avoid spurious out

[issue19884] Importing readline produces erroneous output

Martin Panter added the comment: Thanks, I can try to commit the version fix part of the patch when I get a chance. What is EL6.8, is that a Red Hat (Enterprise Linux) thing? -- versions: +Python 3.6 -Python 3.4 ___ Python tracker

[issue19884] Importing readline produces erroneous output

Orion Poplawski added the comment: Updating the version check to 6.1 as in the patch from Martin certainly avoids the failing test. -- ___ Python tracker ___ __

[issue19884] Importing readline produces erroneous output

Orion Poplawski added the comment: I'm still seeing this test failure on EL6.8 with python 3.4.5: [268/391] test_readline testHistoryUpdates (test.test_readline.TestHistoryManipulation) ... ok test_init (test.test_readline.TestReadline) ... test test_readline failed FAIL

[issue19884] Importing readline produces erroneous output

Martin Panter added the comment: Here is a patch to enable the workaround on OS X, and to adjust the test condition to 6.1. It would be nice if someone with OS X and Gnu Readline can confirm that this fixes the problem. -- stage: needs patch -> patch review Added file: http://bugs.pyth

[issue19884] Importing readline produces erroneous output

Martin Panter added the comment: Yogesh: Victor’s patch has already been applied. What is left to do is another patch that enables Victor’s code on OS X when Gnu Readline is being used, as opposed to the usual Apple Editline. Also, I think it is valid to update the version check to 6.1. Accord

[issue19884] Importing readline produces erroneous output

Yogesh Joshi added the comment: I tried applying this patch and its failing and throwing the following error: patching file Lib/test/test_readline.py Hunk #1 FAILED at 1. Hunk #2 FAILED at 43. 2 out of 2 hunks FAILED -- saving rejects to file Lib/test/test_readline.py.rej patching file Modules/r

[issue19884] Importing readline produces erroneous output

Berker Peksag added the comment: The version check doesn't work because 0ed1801bf4bd added #ifndef __APPLE__ to guard the code, so if you're using readline on OS X, that rl_variable_bind workaround won't work. There are two alternatives: 1) convert ifndef to ifdef and add a check for the ``us

[issue19884] Importing readline produces erroneous output

Isaac Schwabacher added the comment: Whoops, that's 0x0601. Though Maxime gives evidence that the version should in fact be 0x0603. (Note that while OS X ships with libedit over libreadline, anyone who wants to can install the real thing instead of that pale imitation; the test would have be

[issue19884] Importing readline produces erroneous output

Isaac Schwabacher added the comment: >From the OP: > This was reported at [1] and originally at [2]. The readline maintainer > suggests [3] using: > > rl_variable_bind ("enable-meta-key", "off"); > > which was introduced in readline 6.1. Do you think it'd be safe to add the > above line?

[issue19884] Importing readline produces erroneous output

STINNER Victor added the comment: Mac OS X uses libedit, not libreadline. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19884] Importing readline produces erroneous output

Maxime Belanger added the comment: I think the version check (`readline._READLINE_VERSION < 0x0600`) is incorrect, as the test still fails for me on Mac OS X 10.9 with readline version 6.2 (0x602). Upgrading to 6.3 (0x603) fixes it, though. -- nosy: +Maxime Belanger __

[issue19884] Importing readline produces erroneous output

Changes by Vinson Lee : -- nosy: +vlee ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/

[issue19884] Importing readline produces erroneous output

STINNER Victor added the comment: Arfever, Antoine: If buildbots are happy (green), you can close the issue. (I'm answering to your question on IRC ;-)) -- ___ Python tracker __

[issue19884] Importing readline produces erroneous output

Roundup Robot added the comment: New changeset eba6e68e818c by Antoine Pitrou in branch '2.7': Issue #22773: fix failing test with old readline versions due to issue #19884. https://hg.python.org/cpython/rev/eba6e68e818c -- ___ Python tracker

[issue19884] Importing readline produces erroneous output

Roundup Robot added the comment: New changeset c4b5a5d44254 by Antoine Pitrou in branch '3.4': Issue #22773: fix failing test with old readline versions due to issue #19884. https://hg.python.org/cpython/rev/c4b5a5d44254 New changeset be374b8c40c8 by Antoine Pitrou in branch 'default': Issue #22

[issue19884] Importing readline produces erroneous output

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue19884] Importing readline produces erroneous output

David Edelsohn added the comment: Issue22773 provides a patch to export Readline version and skip the test for earlier releases of libreadline where turning off enable-meta-key does not work. -- nosy: +David.Edelsohn ___ Python tracker

[issue19884] Importing readline produces erroneous output

Changes by Stefan Krah : -- nosy: -skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue19884] Importing readline produces erroneous output

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19884] Importing readline produces erroneous output

STINNER Victor added the comment: The test fails on some platforms but it's not a regression. -- ___ Python tracker ___ ___ Python-bug

[issue19884] Importing readline produces erroneous output

Ned Deily added the comment: Should this be a release blocker for 3.4.2? -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue19884] Importing readline produces erroneous output

Benjamin Peterson added the comment: It seems this bug was fixed properly by readline in version 6.3; rl_initialize won't put meta codes on the screen. Frankly, I'm surprised distros like Fedora haven't upgraded or patched readline themselves to fix this. Aren't other programs affected? Turni

[issue19884] Importing readline produces erroneous output

Changes by Geoffrey Spear : -- nosy: +geoffreyspear ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19884] Importing readline produces erroneous output

Changes by Remi Pointel : -- nosy: +rpointel ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19884] Importing readline produces erroneous output

Edd Barrett added the comment: This problem shows up on OpenBSD too. It breaks 'hg view' also. -- nosy: +Edd.Barrett ___ Python tracker ___ __

[issue19884] Importing readline produces erroneous output

STINNER Victor added the comment: Oh, the test also fails on the new Red Hat 6 buildbot: http://buildbot.python.org/all/builders/x86%20RHEL%206%203.x/builds/4358/steps/test/logs/stdio == FAIL: test_init (test.test_readline.Test

[issue19884] Importing readline produces erroneous output

STINNER Victor added the comment: The test fails also on OpenBSD: http://buildbot.python.org/all/builders/x86%20OpenBSD%205.5%203.x/builds/671/steps/test/logs/stdio == FAIL: test_init (test.test_readline.TestReadline) -

[issue19884] Importing readline produces erroneous output

Roundup Robot added the comment: New changeset f0ab6f9f0603 by Victor Stinner in branch '2.7': Issue #19884, readline: calling rl_variable_bind ("enable-meta-key", "off") http://hg.python.org/cpython/rev/f0ab6f9f0603 New changeset 3f08c1156050 by Victor Stinner in branch '3.4': Issue #19884, rea

[issue19884] Importing readline produces erroneous output

Ned Deily added the comment: Currently, readline.c uses #ifdef __APPLE__ to guard libedit-specific code (there is another open issue to generalize libedit support to other platforms). -- ___ Python tracker ___

[issue19884] Importing readline produces erroneous output

STINNER Victor added the comment: > The changes are also causing segfaults when readline is linked with BSD > libedit (the default on OS X) rather than GNU readline: Oh wow. Do you have an idea of to fix the issue with libedit? Or make the code condition, only use it with native readline?

[issue19884] Importing readline produces erroneous output

Ned Deily added the comment: The changes are also causing segfaults when readline is linked with BSD libedit (the default on OS X) rather than GNU readline: == FAIL: test_init (test.test_readline.TestReadline) -

[issue19884] Importing readline produces erroneous output

STINNER Victor added the comment: The test fails on AMD64 OpenIndiana 2.7: http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%202.7/builds/2354/steps/test/logs/stdio test test_readline failed -- Traceback (most recent call last): File "/export/home/buildbot/64bits/2.7.cea-indiana-am

[issue19884] Importing readline produces erroneous output

STINNER Victor added the comment: I commited my patch. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Pyth

[issue19884] Importing readline produces erroneous output

Roundup Robot added the comment: New changeset 0177d8a4e82a by Victor Stinner in branch '2.7': Issue #19884: readline: Disable the meta modifier key if stdout is not a http://hg.python.org/cpython/rev/0177d8a4e82a New changeset 6303266beb80 by Victor Stinner in branch '3.4': Issue #19884: readli

[issue19884] Importing readline produces erroneous output

STINNER Victor added the comment: Attached readline_disable_meta_key.patch: Implement the workaround suggested in (*), but only use the workaround if stdout is not a TTY (ex: output redirected), to limit the risk of regression. (*) http://lists.gnu.org/archive/html/bug-readline/2011-04/msg

[issue19884] Importing readline produces erroneous output

Antoine Pitrou added the comment: We seem to have gotten bit by this in issue21425. Dave, is it possible for you to validate the proposed fix? I can't test this under Ubuntu. Setting priority to "high" as it seems to actually annoy many people: http://stackoverflow.com/questions/15760712/pyth

[issue19884] Importing readline produces erroneous output

Bohuslav "Slavek" Kabrda added the comment: I can also reproduce it on Arch Linux. It seems that the bad characters are only output if env variable TERM starts with "xterm". -- ___ Python tracker _

[issue19884] Importing readline produces erroneous output

Vajrasky Kok added the comment: Reproducible under Fedora 18. $ ./python -c "import readline" | hexdump -C 1b 5b 3f 31 30 33 34 68 |.[?1034h| 0008 $ TERM=dumb ./python -c "import readline" | hexdump -C -- nosy: +vajrasky

[issue19884] Importing readline produces erroneous output

Antoine Pitrou added the comment: I can't reproduce under Ubuntu 13.10. Is this Red Hat-specific? (according to Dave, """This is a readline bug; it looks like it should not emit those characters when stdout is not a tty""") -- nosy: +dmalcolm, pitrou versions: +Python 3.4

[issue19884] Importing readline produces erroneous output

New submission from Bohuslav "Slavek" Kabrda: A simple reproducer: python -c 'import readline' | xxd 000: 1b5b 3f31 3033 3468 .[?1034h This was reported at [1] and originally at [2]. The readline maintainer suggests [3] using: rl_variable_bind ("enable-meta-key", "off