[issue19828] test_site fails with -S flag

Zachary Ware added the comment: Fixed. Thank you Vajrasky for raising the issue, and David for the much better wording. -- assignee: -> zach.ware resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: +Python 3.3 ___ P

[issue19828] test_site fails with -S flag

Roundup Robot added the comment: New changeset 40884256f8dd by Zachary Ware in branch '3.3': Issue #19828: Fixed test_site when the whole suite is run with -S. http://hg.python.org/cpython/rev/40884256f8dd New changeset 90834ad91d56 by Zachary Ware in branch 'default': Issue #19828: Merge with 3

[issue19828] test_site fails with -S flag

R. David Murray added the comment: I would just change the comment to "it is not useful to run the tests if we were called with -S". Otherwise it looks fine. If someone adds tests that are meaningful with -S is specified, we can put them in a different class, and move the skip to the class le

[issue19828] test_site fails with -S flag

Zachary Ware added the comment: Looking more closely, there's not much that looks like it really should be tested if explicitly called with -S, so perhaps the toplevel skip is still best after all. Any other thoughts? Attached patch fixes `python -S Lib/test` and cleans up an unused import. I

[issue19828] test_site fails with -S flag

Zachary Ware added the comment: The real issue here is that the test used to determine whether -S was passed or not is outdated: instead of checking sys.flags.no_site, it checks whether 'site' is in sys.modules. This is no longer a valid test, since site's side effects are contained within si

[issue19828] test_site fails with -S flag

Vajrasky Kok added the comment: Sorry to forget to add the relevant detail: $ ./python -S Lib/test [284/387] test_shutil [285/387] test_signal [286/387] test_site test test_site failed -- multiple errors occurred; run in verbose mode for details [287/387/1] test_slice [288/387/1] test_smtp

[issue19828] test_site fails with -S flag

Vajrasky Kok added the comment: Yeah, but... $ ./python -S Lib/test == CPython 3.4.0b1 (default:373797990f57, Dec 2 2013, 16:46:35) [GCC 4.7.2] == Linux-3.5.0-37-generic-x86_64-with-debian-wheezy-sid little-endian == hash algorithm: siphash24 64bit == /home/ethan/Documents/code/python/cpyt

[issue19828] test_site fails with -S flag

R. David Murray added the comment: That's not relevant, though. In fact, the existing error message for running the module directly is exactly correct: the entire test module fails to run, which is a more accurate reflection of the reality than showing all of the individual tests as skipped.

[issue19828] test_site fails with -S flag

Vajrasky Kok added the comment: Before patch: $ ./python -S Lib/test/test_site.py Traceback (most recent call last): File "Lib/test/test_site.py", line 28, in raise unittest.SkipTest("importation of site.py suppressed") unittest.case.SkipTest: importation of site.py suppressed After patc

[issue19828] test_site fails with -S flag

R. David Murray added the comment: See also issue 1674555, which aims to make test_site run without -S and everything else run with -S. I think this issue is invalid, if I understand what you wrote correctly, since test_site *should* be reported as a skipped test if -S is specified.

[issue19828] test_site fails with -S flag

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue19828] test_site fails with -S flag

Changes by Zachary Ware : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue19828] test_site fails with -S flag

New submission from Vajrasky Kok: $ ./python -S Lib/test/test_site.py Traceback (most recent call last): File "Lib/test/test_site.py", line 28, in raise unittest.SkipTest("importation of site.py suppressed") unittest.case.SkipTest: importation of site.py suppressed This counts as fail te