[issue19726] BaseProtocol is not an ABC

2013-11-30 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- versions: +Python 3.4 -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mail

[issue19726] BaseProtocol is not an ABC

2013-11-30 Thread Nick Coghlan
Changes by Nick Coghlan : -- Removed message: http://bugs.python.org/msg204783 ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue19726] BaseProtocol is not an ABC

2013-11-30 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5469e1a68dbd by Guido van Rossum in branch 'default': asyncio: Use Interface instead of ABC. Fixes issue 19726. http://hg.python.org/cpython/rev/5469e1a68dbd -- ___ Python tracker

[issue19726] BaseProtocol is not an ABC

2013-11-30 Thread Guido van Rossum
Changes by Guido van Rossum : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue19726] BaseProtocol is not an ABC

2013-11-30 Thread Guido van Rossum
Guido van Rossum added the comment: You're right, I commented previously without reading the context. The classes defined in protocol.py are not ABCs, they are just base classes (and not mandatory, just convenient, because the transport *will* assume all methods are implemented, and call them

[issue19726] BaseProtocol is not an ABC

2013-11-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Well, it *is* abstract because it has no implementations and all the > methods raise NotImplementedError. Hmm, actually, the methods don't raise NotImplementedError, they just have default empty implementations. -- __

[issue19726] BaseProtocol is not an ABC

2013-11-30 Thread Alexandre Vassalotti
Changes by Alexandre Vassalotti : -- Removed message: http://bugs.python.org/msg204785 ___ Python tracker ___ ___ Python-bugs-list mai

[issue19726] BaseProtocol is not an ABC

2013-11-30 Thread Rhonda Parker
Rhonda Parker added the comment: T0 the people that manipulate universe of linux and unix based protocol should take in consideration when people skilled programming introduce downloads and install protocol to those unskilled in the like because it only creates a disassociation resulting in th

[issue19726] BaseProtocol is not an ABC

2013-11-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 04088790c077 by Nick Coghlan in branch 'default': Issue #19726: actually running 'hg add' helps... http://hg.python.org/cpython/rev/04088790c077 -- nosy: +python-dev ___ Python tracker

[issue19726] BaseProtocol is not an ABC

2013-11-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Well, it *is* abstract because it has no implementations and all the > methods raise NotImplementedError. We can do better in the .rst docs though. I didn't know what to do with it, so I didn't mention it at all in the .rst docs :-) -- __

[issue19726] BaseProtocol is not an ABC

2013-11-23 Thread Guido van Rossum
Guido van Rossum added the comment: Well, it *is* abstract because it has no implementations and all the methods raise NotImplementedError. We can do better in the .rst docs though. -- ___ Python tracker __

[issue19726] BaseProtocol is not an ABC

2013-11-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Well, IMHO it's better spelt "base class" if it isn't technically an ABC. At least I was personally a bit surprised at first. -- ___ Python tracker ___

[issue19726] BaseProtocol is not an ABC

2013-11-23 Thread Guido van Rossum
Guido van Rossum added the comment: I'm not sure that "ABC" implies "an instance of abc.ABC". It's still an abstract base class (in the usual definition of that concept) even if it doesn't enforce anything. I propose to close this as wontfix. -- __

[issue19726] BaseProtocol is not an ABC

2013-11-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: I don't think it's necessary either. They don't *need* to be ABCs, but if they aren't the docstring should be fixed :) -- ___ Python tracker __

[issue19726] BaseProtocol is not an ABC

2013-11-22 Thread Guido van Rossum
Guido van Rossum added the comment: Good question. I don't mind making these ABCs, but I don't think it's necessary to do it before beta1 (since it won't matter for most people). -- ___ Python tracker

[issue19726] BaseProtocol is not an ABC

2013-11-22 Thread Antoine Pitrou
New submission from Antoine Pitrou: BaseProtocol docstring describes it as an "ABC for base protocol class", but it is not actually an ABC in the technical sense. -- assignee: gvanrossum components: Library (Lib) messages: 203921 nosy: gvanrossum, pitrou priority: normal severity: norma