[issue19713] Deprecate various things in importlib thanks to PEP 451

Changes by Petr Viktorin : -- nosy: +encukou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19713] Deprecate various things in importlib thanks to PEP 451

Roundup Robot added the comment: New changeset c0b0e7aef360 by Eric Snow in branch 'default': Issue 19713: Remove PEP 451-related code that should have been factored out. http://hg.python.org/cpython/rev/c0b0e7aef360 -- ___ Python tracker

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: Good catch. I've gone through looking for other such left-overs from earlier patches that included deprecation warnings for loader.load_module(), but this is the only one I found. However, I did notice that _SpecMethods.from_module() does not get used anywhere.

[issue19713] Deprecate various things in importlib thanks to PEP 451

Arfrever Frehtes Taifersar Arahesis added the comment: > New changeset 37caaf21f827 by Eric Snow in branch 'default': > Issue 19713: Add PEP 451-related deprecations. > http://hg.python.org/cpython/rev/37caaf21f827 > ... > -spec.loader.load_module(spec.name) > +try: > +

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: Also: changeset: 88332:bfcbe41e892d4451b53bb5674fc4fa4ae791ec8c user:Eric Snow date:Mon Jan 06 20:42:59 2014 -0700 summary: Remove more usage of APIs deprecated by PEP 451. -- ___ Python tracker

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: Larry: There wasn't any API change for this issue. It was a matter of fixing up places that were still using find_module/find_loader/load_module. -- resolution: -> fixed stage: test needed -> committed/rejected status: open -> closed

[issue19713] Deprecate various things in importlib thanks to PEP 451

Roundup Robot added the comment: New changeset 37caaf21f827 by Eric Snow in branch 'default': Issue 19713: Add PEP 451-related deprecations. http://hg.python.org/cpython/rev/37caaf21f827 -- ___ Python tracker _

[issue19713] Deprecate various things in importlib thanks to PEP 451

Larry Hastings added the comment: I can accept the fourth patch in its current state. Is that a rollup patch, including all the previous patches, or is it independent? Is there a patch I can look at for this new API? -- ___ Python tracker

[issue19713] Deprecate various things in importlib thanks to PEP 451

Changes by Eric Snow : -- dependencies: +Check pkgutil for anything missing for PEP 451 ___ Python tracker ___ ___ Python-bugs-list ma

[issue19713] Deprecate various things in importlib thanks to PEP 451

Changes by Eric Snow : -- assignee: -> eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue19713] Deprecate various things in importlib thanks to PEP 451

Changes by Eric Snow : Removed file: http://bugs.python.org/file33202/issue19713-deprecation-warnings.diff ___ Python tracker ___ ___ Python-

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: Here's a patch that should round out the changes for this ticket, adding the various deprecation warnings. Most of the patch involves silencing warnings or cleaning up importlib tests relative to the deprecated APIs. -- ___

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: ...and the patch. -- Added file: http://bugs.python.org/file33315/issue19713-deprecation-warnings.diff ___ Python tracker ___ __

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: Okay, there were a few lingering changes (mostly related to importlib.find_loader). Here's a patch. -- Added file: http://bugs.python.org/file33314/issue19713-more-API-adjustments.diff ___ Python tracker

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: Hmm. That's a good question. There really isn't a simple, public-API replacement. I've opened issue #20125 to discuss our options. Feel free to offer any suggestions there. Thanks for bringing this up. -- ___ Python

[issue19713] Deprecate various things in importlib thanks to PEP 451

Nick Coghlan added the comment: Arfrever: not at this point. We really should have an importlib.util.load_from_spec() that hides those internal details. Larry - can we get away with adding that? It didn't become obvious it was a missing API until Eric started doing these conversions.

[issue19713] Deprecate various things in importlib thanks to PEP 451

Arfrever Frehtes Taifersar Arahesis added the comment: About last commit: Is there a way to avoid using private objects when removing uses of load_module? -- ___ Python tracker

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: I should clarify. That last commit was not the patch that adds the warnings. I'm going to update that patch and attach it here when I get the chance. -- ___ Python tracker __

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: At this point the only places using find_module and load_module are pydoc, importlib, and some oddballs that aren't worth worrying about. Issue #19703 covers the pydoc changes. -- dependencies: +Update pydoc to PEP 451

[issue19713] Deprecate various things in importlib thanks to PEP 451

Roundup Robot added the comment: New changeset a18c1a4cf30a by Eric Snow in branch 'default': Issue #19713: Move away from using find_module/load_module. http://hg.python.org/cpython/rev/a18c1a4cf30a -- ___ Python tracker

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: Here's a patch that updates a couple files to not use find_module/load_module. These are the only changes like this (of consequence) outside pydoc, pkgutil, and importlib, which are covered by other tickets. -- Added file: http://bugs.python.org/file33300/

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: Sounds good. Thanks for the explanation. It sounds like you're effectively concerned just with finder.find_module() and loader.load_module() (which is fine with me). Everything else (including some of the ABCs) is 3.3-only. For the sake of simplicity I could al

[issue19713] Deprecate various things in importlib thanks to PEP 451

Nick Coghlan added the comment: Test suites enable deprecation warnings by default, and many projects have a "no warnings allowed" rule. By adding programmatic deprecation warnings for the old APIs where there's no other way to it in a 3.3 compatible way, we make things more difficult for people

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: I'm glad you spoke up, Nick. Holding off on the DeprecationWarnings is fine with me. It's not like we are going to drop support for the APIs before Python 4! That said, DeprecationWarnings are disabled by default. So how big a deal do you think it is to leave t

[issue19713] Deprecate various things in importlib thanks to PEP 451

Nick Coghlan added the comment: Please don't emit a deprecation warning for loaders that only implement load_module - there are still things load_module can do that create/exec can't, and it's still possible it will remain the long term API for those use cases. Plus builtins and extensions are

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: Here's an updated patch that does most of the deprecations and adjustments/silencings to accommodate the deprecations. The main things left to adjust are many importlib tests and pkgutil/test_pkgutil. I'm still on the fence about deprecation warnings for module_re

[issue19713] Deprecate various things in importlib thanks to PEP 451

Changes by Eric Snow : Removed file: http://bugs.python.org/file33172/issue19713-deprecation-warnings.diff ___ Python tracker ___ ___ Python-

[issue19713] Deprecate various things in importlib thanks to PEP 451

Brett Cannon added the comment: * Yes, you can commit with the warnings being triggered to get help with resolving them, just expect to potentially do a lot of work to make sure they don't leak out into 3.4 final. * Just don't deprecate load_module() yet in code. If we can't even get rid of a

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: I'd meant to do that. I'll update the patch when I have a chance. -- ___ Python tracker ___ ___ Python-b

[issue19713] Deprecate various things in importlib thanks to PEP 451

Serhiy Storchaka added the comment: Could you please use correct stacklevel, such that warnings will point to places where deprecated function used, not where they are defined? -- nosy: +serhiy.storchaka ___ Python tracker

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: Here's a patch that simply adds all the deprecation warnings. It does not include any effort to silence the zillion warnings that happen when the test suite is run with -Wall. I plan on addressing all those when I have some time. That will be a matter of refacto

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: P.S. changeset b78de8029606 should have referred to #19710. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: The doc deprecations should now be complete. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19713] Deprecate various things in importlib thanks to PEP 451

Roundup Robot added the comment: New changeset 2c27c0e5bc50 by Eric Snow in branch 'default': Issue #19713: Update importlib docs for module spec changes, including deprecations. http://hg.python.org/cpython/rev/2c27c0e5bc50 New changeset b78de8029606 by Eric Snow in branch 'default': Issue #19

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: Here's a patch for the deprecations (and API additions) in the importlib docs. -- keywords: +patch Added file: http://bugs.python.org/file33088/issue19713-importlib-docs.diff ___ Python tracker

[issue19713] Deprecate various things in importlib thanks to PEP 451

Brett Cannon added the comment: To add another point about load_module(), I just had to rip out exec_module() for Python 3.4 as working around _imp.init_builtin() and _imp.load_dynamic() are going to need to be done hand-in-hand. So load_module() should probably get documented as deprecated an

[issue19713] Deprecate various things in importlib thanks to PEP 451

Nick Coghlan added the comment: I think we should definitely support them, I just haven't thought of a way to do that yet which is cleaner than the status quo (it's only the loader part of the API that isn't fully covered - the rest of the legacy APIs can be deprecated happily). I may come up wit

[issue19713] Deprecate various things in importlib thanks to PEP 451

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue19713] Deprecate various things in importlib thanks to PEP 451

Brett Cannon added the comment: I do not think we should keep the old APIs around forever, so either we don't care about the obscure use cases or figure out a way to support them. -- ___ Python tracker ___

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: It's definitely worth it to be more explicit. (Brett had referenced msg202663.) When I get some time I'll update this ticket with a list of the specific deprecation items. -- ___ Python tracker

[issue19713] Deprecate various things in importlib thanks to PEP 451

Nick Coghlan added the comment: Keep in mind we figured out post-PEP acceptance that there are still a couple of obscure use cases that need the old loader API, so we may want to keep that around as a "power user" mode rather than deprecating it (either forever or until a replacement is defined i

[issue19713] Deprecate various things in importlib thanks to PEP 451

Eric Snow added the comment: See http://www.python.org/dev/peps/pep-0451/#deprecations. -- ___ Python tracker ___ ___ Python-bugs-list

[issue19713] Deprecate various things in importlib thanks to PEP 451

Brett Cannon added the comment: Also msg202663 and msg202664 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19713] Deprecate various things in importlib thanks to PEP 451

New submission from Brett Cannon: http://bugs.python.org/msg202659 -- messages: 203807 nosy: brett.cannon, eric.snow, ncoghlan priority: normal severity: normal stage: test needed status: open title: Deprecate various things in importlib thanks to PEP 451 versions: Python 3.4 __