[issue19593] Use specific asserts in importlib tests

2014-07-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: commit review -> resolved status: open -> closed versions: +Python 3.4 ___ Python tracker ___

[issue19593] Use specific asserts in importlib tests

2014-07-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Ezio for the review. I hope issue18864 will be merged without conflicts. -- dependencies: -Implementation for PEP 451 (importlib.machinery.ModuleSpec) resolution: -> fixed ___ Python tracker

[issue19593] Use specific asserts in importlib tests

2014-07-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset f426bd85f808 by Serhiy Storchaka in branch '3.4': Issue #19593: Use specific asserts in importlib tests. http://hg.python.org/cpython/rev/f426bd85f808 New changeset cace5cc29df0 by Serhiy Storchaka in branch 'default': Issue #19593: Use specific ass

[issue19593] Use specific asserts in importlib tests

2014-07-05 Thread Brett Cannon
Brett Cannon added the comment: Ezio already gave a commit review. Serhiy just needs to commit it himself. -- assignee: -> serhiy.storchaka stage: patch review -> commit review ___ Python tracker _

[issue19593] Use specific asserts in importlib tests

2014-07-04 Thread Mark Lawrence
Mark Lawrence added the comment: Can we have a commit review on this please. I've already asked for reviews on #18864 and its dependencies. -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker

[issue19593] Use specific asserts in importlib tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: Patch LGTM. -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue19593] Use specific asserts in importlib tests

2013-11-15 Thread Nick Coghlan
Nick Coghlan added the comment: Adding a dependency on the PEP 451 implementation - we should merge that first to ensure it doesn't encounter any conflicts. -- dependencies: +Implementation for PEP 451 (importlib.machinery.ModuleSpec) ___ Python trac

[issue19593] Use specific asserts in importlib tests

2013-11-14 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: The proposed patch makes the importlib package tests use more specific asserts. This will provide more useful failure report. -- components: Tests files: test_importlib_asserts.patch keywords: patch messages: 202885 nosy: brett.cannon, eric.snow, nc