[issue19590] Use specific asserts in test_email

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your review. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue19590] Use specific asserts in test_email

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 27567e954cbe by Serhiy Storchaka in branch '2.7': Issue #19590: Use specific asserts in email tests. http://hg.python.org/cpython/rev/27567e954cbe New changeset db6ea9abd317 by Serhiy Storchaka in branch '3.3': Issue #19590: Use specific asserts in

[issue19590] Use specific asserts in test_email

2013-11-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: assertTrue(dtrt) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue19590] Use specific asserts in test_email

2013-11-15 Thread R. David Murray
R. David Murray added the comment: Additional changes look good to me. Unless (pun intended) Barry objects, I think I'll come down in favor of backporting all of these changes. The tipping point is that I've always found myself experiencing cognitive dissonance reading the 'unless' calls, sin

[issue19590] Use specific asserts in test_email

2013-11-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch which includes only added changes. Such small and straightforward changes are easier to review by looking at colorized `hg diff` output. -- Added file: http://bugs.python.org/file32630/test_email_asserts_2_diff.patch

[issue19590] Use specific asserts in test_email

2013-11-14 Thread R. David Murray
R. David Murray added the comment: Any chance of getting a patch with the just the added changes? I'd rather not fish through the stuff I've already looked at looking for the new stuff. I'm of two minds about the advisability of backporting this. -- __

[issue19590] Use specific asserts in test_email

2013-11-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: And here is a patch for 2.7. -- versions: +Python 2.7 Added file: http://bugs.python.org/file32628/test_email_asserts_2-2.7.patch ___ Python tracker _

[issue19590] Use specific asserts in test_email

2013-11-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is larger patch (some asserts were aliased). It is applicable to 3.3 too. -- versions: +Python 3.3 Added file: http://bugs.python.org/file32627/test_email_asserts_2.patch ___ Python tracker

[issue19590] Use specific asserts in test_email

2013-11-14 Thread R. David Murray
R. David Murray added the comment: Looks fine to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue19590] Use specific asserts in test_email

2013-11-14 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: The proposed patch makes test_email use more specific asserts. This will provide more useful failure report. -- components: Tests, email files: test_email_asserts.patch keywords: patch messages: 202881 nosy: barry, r.david.murray, serhiy.storchaka p