[issue19527] Test failures with COUNT_ALLOCS

STINNER Victor added the comment: New changeset 7b4ba62e388474e811268322b47f80d464933541 by Victor Stinner in branch '2.7': [2.7] bpo-31692: Add PYTHONSHOWALLOCCOUNT env var (GH-3927) https://github.com/python/cpython/commit/7b4ba62e388474e811268322b47f80d464933541 -- __

[issue19527] Test failures with COUNT_ALLOCS

Change by STINNER Victor : -- pull_requests: +3902 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19527] Test failures with COUNT_ALLOCS

Change by STINNER Victor : -- pull_requests: +3883 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19527] Test failures with COUNT_ALLOCS

Serhiy Storchaka added the comment: All tests now are passed in 3.6 on Linux. Making them passing in 3.5 requires too much changes that are not needed in 3.6. I don't think we need to pollute tests with these temporary workarounds. -- resolution: -> fixed stage: patch review -> resolv

[issue19527] Test failures with COUNT_ALLOCS

Roundup Robot added the comment: New changeset 5abf6cdcac4d by Serhiy Storchaka in branch '3.5': Issue #19527: Fixed tests with defined COUNT_ALLOCS. https://hg.python.org/cpython/rev/5abf6cdcac4d New changeset e7d84ecdd37d by Serhiy Storchaka in branch 'default': Issue #19527: Fixed tests with

[issue19527] Test failures with COUNT_ALLOCS

STINNER Victor added the comment: I propose to emit a compiler warning (or even an error?) in 3.5.x and drop the code in 3.6. I don't think that a long deprecation period is requied. The feature is not widely used. -- ___ Python tracker

[issue19527] Test failures with COUNT_ALLOCS

Bohuslav "Slavek" Kabrda added the comment: > IMHO these two debug features superseded COUNT_ALLOCS. Please try to convince > me of the use case of this very old debug feature. I no longer use this feature and I think that noone does. As you said, it seems to be obsoleted by other new features

[issue19527] Test failures with COUNT_ALLOCS

Serhiy Storchaka added the comment: Yes, I also don't want to use 00141-fix-tests_with_COUNT_ALLOCS-v5.patch if there is better alternative. See issue23034 (I'm uncertain only in option name). -- ___ Python tracker

[issue19527] Test failures with COUNT_ALLOCS

Robert Kuska added the comment: FYI There is also issue23034 where is proposed "-X showalloccount" option to suppress the output, we use (custom patch) environment variable to filter out the verbose output in Fedora. -- ___ Python tracker

[issue19527] Test failures with COUNT_ALLOCS

STINNER Victor added the comment: 00141-fix-tests_with_COUNT_ALLOCS-v5.patch: please don't do that! It makes tests much more verbose for a compilation option which is hidden and probably almost never used in the wild. The option has no configuration option for example. *If* you really want to

[issue19527] Test failures with COUNT_ALLOCS

STINNER Victor added the comment: COUNT_ALLOCS was added 22 years ago. I guess that the usecase is to track memory leaks, right? branch: legacy-trunk user:Sjoerd Mullender date:Mon Oct 11 12:54:31 1993 + files: Include/object.h Modules/arraymodule.c Modules/confi

[issue19527] Test failures with COUNT_ALLOCS

Robert Kuska added the comment: With Python-3.5 and COUNT_ALLOCS enabled following new tests fail also: FAIL: test_is_finalizing (test.test_sys.SysModuleTest) -- Traceback (most recent call last): File "/builddir/build/BUILD/

[issue19527] Test failures with COUNT_ALLOCS

Serhiy Storchaka added the comment: Thenks Antoine for great idea proposed in comments on Rietveld. Following patch introduces strip_python_stdout() which strips COUNT_ALLOCS debug output from stdout (unfortunately this operation is not always unambiguous) and call it in assert_python_ok() and

[issue19527] Test failures with COUNT_ALLOCS

Serhiy Storchaka added the comment: LGTM (only one nitpick -- there are trailing spaces in test_gc). But there are other tests which are failed with COUNT_ALLOCS. Here is a patch with additional fixes for these tests in test_gc and test_warnings. -- Added file: http://bugs.python.org/

[issue19527] Test failures with COUNT_ALLOCS

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19527] Test failures with COUNT_ALLOCS

Bohuslav "Slavek" Kabrda added the comment: Good catch, using getrefcount was a mistake. I'm attaching a new version which always checks for getcounts (and also applies on 3.4.2). -- Added file: http://bugs.python.org/file37414/00141-fix-tests_with_COUNT_ALLOCS-v3.patch __

[issue19527] Test failures with COUNT_ALLOCS

Serhiy Storchaka added the comment: Why do you check hasattr(sys, 'getrefcount') in test_io.py, but hasattr(sys, 'getcounts') in all other tests? -- ___ Python tracker ___ _

[issue19527] Test failures with COUNT_ALLOCS

Changes by Serhiy Storchaka : -- components: +Tests nosy: +serhiy.storchaka stage: -> patch review type: -> behavior versions: +Python 3.5 ___ Python tracker ___ __

[issue19527] Test failures with COUNT_ALLOCS

Bohuslav "Slavek" Kabrda added the comment: As noted in Misc/SpecialBuilds: COUNT_ALLOCS Each type object grows three new members: /* Number of times an object of this type was allocated. */ int tp_allocs; /* Number of times an object of this type was deallocated. */

[issue19527] Test failures with COUNT_ALLOCS

STINNER Victor added the comment: What is COUNT_ALLOCS? Python 3.4 now has sys.getallocatedblocks() and a new tracemalloc module which are compiled by default. -- ___ Python tracker __

[issue19527] Test failures with COUNT_ALLOCS

Bohuslav "Slavek" Kabrda added the comment: Since 3.4.0.b2, this also causes failures in another tests: test_io, test_logging, test_threading, test_warnings. There are various cases testing that some types get collected when the interpreter shuts down. I'm attaching a new patch that covers all

[issue19527] Test failures with COUNT_ALLOCS

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19527] Test failures with COUNT_ALLOCS

Bohuslav "Slavek" Kabrda added the comment: And the patch... -- keywords: +patch Added file: http://bugs.python.org/file32540/00141-fix-tests_with_COUNT_ALLOCS.patch ___ Python tracker

[issue19527] Test failures with COUNT_ALLOCS

New submission from Bohuslav "Slavek" Kabrda: When Python is compiled with COUNT_ALLOCS, some tests in test_gc and test_module fail. I'm attaching the patch that skips 3 of them and modifies assertions in one of them, so that the tests pass. I'm however still unsure about one of the skipped te