[issue19520] Win32 compiler warning in _sha3

2013-11-17 Thread Zachary Ware
Zachary Ware added the comment: Thanks Christian, now committed. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue19520] Win32 compiler warning in _sha3

2013-11-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset 259c82332199 by Zachary Ware in branch 'default': Issue #19520: Fix (the last!) compiler warning on 32bit Windows, in _sha3 http://hg.python.org/cpython/rev/259c82332199 -- nosy: +python-dev ___ Python tr

[issue19520] Win32 compiler warning in _sha3

2013-11-17 Thread Christian Heimes
Christian Heimes added the comment: Go ahead! Although I'd rather follow upstream as close as possible, this one is harmless. -- assignee: christian.heimes -> zach.ware stage: needs patch -> patch review ___ Python tracker

[issue19520] Win32 compiler warning in _sha3

2013-11-07 Thread Christian Heimes
Christian Heimes added the comment: Thanks! I'll look into it. I'd rather not change the reference implementation but in this case practicality beats purity. :) -- assignee: -> christian.heimes ___ Python tracker

[issue19520] Win32 compiler warning in _sha3

2013-11-07 Thread Zachary Ware
New submission from Zachary Ware: There is only one remaining compiler warning on 32-bit Windows, see [1] (buildbot doubles warning counts on the Windows bots). The warning is coming from Modules/_sha3/keccak/KeccakF-1600-opt32.c#l497, which uses extractLanes as defined on line 213. The attac