[issue19378] Clean up Python 3.4 API additions in the dis module

Roundup Robot added the comment: New changeset ce8dd299cdc4 by Nick Coghlan in branch 'default': Close #19378: address flaws in the new dis module APIs http://hg.python.org/cpython/rev/ce8dd299cdc4 -- nosy: +python-dev resolution: -> fixed stage: -> committed/rejected status: open -> c

[issue19378] Clean up Python 3.4 API additions in the dis module

Changes by Nick Coghlan : -- assignee: -> ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19378] Clean up Python 3.4 API additions in the dis module

Nick Coghlan added the comment: There was another change implemented as part of this: trailing whitespace is now stripped from the lines emitted by the disassembler, which made it possible to simplify the tests a bit (since they no longer have to strip that whitespace themselves, they can just

[issue19378] Clean up Python 3.4 API additions in the dis module

Nick Coghlan added the comment: I think it's a good idea in principle, but unrelated to this patch :) This one started as reworking line_offset as a more intuitive "first_line" parameter, and then testing and documenting that change proceeded to reveal a number of other issues with the 3.4 API

[issue19378] Clean up Python 3.4 API additions in the dis module

Larry Hastings added the comment: Would this be a good time for me to ask about publishing the stack effect info? I had to write my own parallel implementation of it for my assembler, so I found it irritating that Python doesn't provide it. -- ___

[issue19378] Clean up Python 3.4 API additions in the dis module

Nick Coghlan added the comment: While working on this, I noticed a number of other issues with the dis API additions for Python 3.4 from issue 11816. Specifically: - the file output redirection API didn't work in some cases that resulted in calls to other disassembly functions - Bytecode.show_