[issue19260] "int" comment in marshal.c is outdated

Larry Hastings added the comment: Martin: The code is not statically type-safe, but it is mechanically safe, which I think is why you wrote the comment in the first place. The return value of fread() is size_t, but the "read" variable is Py_ssize_t. So the function *could* theoretically retur

[issue19260] "int" comment in marshal.c is outdated

Roundup Robot added the comment: New changeset 1309fee48908 by Antoine Pitrou in branch 'default': Close #19260: remove outdated comment in marshal.c http://hg.python.org/cpython/rev/1309fee48908 -- nosy: +python-dev resolution: -> fixed stage: -> committed/rejected status: open -> clo

[issue19260] "int" comment in marshal.c is outdated

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19260] "int" comment in marshal.c is outdated

Martin v. Löwis added the comment: I agree that the comment can be removed. If the code is (now) statically type-safe, there is no point in keeping it. -- nosy: +loewis ___ Python tracker _

[issue19260] "int" comment in marshal.c is outdated

Antoine Pitrou added the comment: Well, the comment should actually be removed, it's just pointless. -- nosy: +pitrou ___ Python tracker ___ _

[issue19260] "int" comment in marshal.c is outdated

Georg Brandl added the comment: The "rXXX" notation is reserved for SVN revision numbers, which are unambiguous. The revision numbers in Mercurial are specific to each clone. Other than that, LGTM. -- nosy: +georg.brandl ___ Python tracker

[issue19260] "int" comment in marshal.c is outdated

New submission from Larry Hastings: In r_string() (read a string) in marshal.c we see this comment: /* The result fits into int because it must be <=n. */ read = fread(p->buf, 1, n, p->fp); This comment was first committed in r36501 by MvL. Back then the "read" and "n" variables were