[issue19201] Add 'x' mode to lzma.open()

Nadeem Vawda added the comment: [terry.reedy] | Arfrever's point about the order of characters makes me wonder why mode | strings (as opposed to characters in the strings) are being checked. | The following tests that exactly one of w, a, x appear in mode. | if len({'w', 'a', 'x'} & set(mode)) =

[issue19201] Add 'x' mode to lzma.open()

Nadeem Vawda added the comment: Fix committed. Thanks for the patches! As Jesús and Terry have said, this won't be backported to 3.3/2.7, since it is a new feature. [oylenshpeegul] | It's weird how different these three patches are! We're | essentially doing the same thing: "please allow the x

[issue19201] Add 'x' mode to lzma.open()

Roundup Robot added the comment: New changeset b7948aaca1dd by Nadeem Vawda in branch 'default': Issue #19201: Add support for the 'x' mode to the lzma module. http://hg.python.org/cpython/rev/b7948aaca1dd -- nosy: +python-dev ___ Python tracker

[issue19201] Add 'x' mode to lzma.open()

Vajrasky Kok added the comment: Stopped the leaking after running the test by adding self.addCleanup. -- Added file: http://bugs.python.org/file32130/add_x_mode_to_lzma_v3.patch ___ Python tracker _

[issue19201] Add 'x' mode to lzma.open()

Vajrasky Kok added the comment: Added doc. Revamped the test. The patch did not cater to the order of modes ("wb" is equal to "bw"?). I think that deserves a separate ticket. -- Added file: http://bugs.python.org/file32077/add_x_mode_to_lzma_v2.patch ___

[issue19201] Add 'x' mode to lzma.open()

Changes by Arfrever Frehtes Taifersar Arahesis : -- components: +Library (Lib) title: Add 'x' mode to lzma.open -> Add 'x' mode to lzma.open() ___ Python tracker ___

[issue19201] Add 'x' mode to lzma.open

Terry J. Reedy added the comment: The bug versus feature issue does not depend on whether the patch could cause a regression. (I think feature patches might actually be less likely than bug fixes to cause regressions, but it does not matter.) Nor is oversight, not adding a feature when it coul