[issue19134] test_inspect.py failed if module _multiprocessing not available

2013-10-02 Thread Remi Pointel
Remi Pointel added the comment: It's ok now, thanks: test_qualname_source (__main__.TestMain) ... skipped 'multiprocessing required to test __qualname__ for source files' -- ___ Python tracker ___

[issue19134] test_inspect.py failed if module _multiprocessing not available

2013-10-02 Thread Brett Cannon
Brett Cannon added the comment: OK, went for a more thorough check for the failure by just trying to import and catching the ImportError instead of trying to be fancy. The FreeBSD buildbot was having the same failure but it seems stuck waiting for some lock, so I can't verify the fix at the mo

[issue19134] test_inspect.py failed if module _multiprocessing not available

2013-10-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2e54edaf60d4 by Brett Cannon in branch 'default': Try to fix issue #19134 again http://hg.python.org/cpython/rev/2e54edaf60d4 -- ___ Python tracker ___

[issue19134] test_inspect.py failed if module _multiprocessing not available

2013-10-02 Thread Remi Pointel
Remi Pointel added the comment: Hi, sorry to reopen this bug but it seams that your commit was not ok: test_qualname_source (__main__.TestMain) ... ERROR == ERROR: test_qualname_source (__main__.TestMain) -

[issue19134] test_inspect.py failed if module _multiprocessing not available

2013-09-30 Thread Remi Pointel
Remi Pointel added the comment: Thanks :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19134] test_inspect.py failed if module _multiprocessing not available

2013-09-30 Thread Brett Cannon
Brett Cannon added the comment: The import doesn't matter for test.support.multiprocessing as it is conditional thanks to the try/except. If that fails then the skipIf will be triggered and nothing will be executed. If the import succeeds in test.support then the importlib.import_module() call

[issue19134] test_inspect.py failed if module _multiprocessing not available

2013-09-30 Thread Roundup Robot
Roundup Robot added the comment: New changeset d7ba4ca59023 by Brett Cannon in branch 'default': Issue #19134: Make a test in inspect conditional on multiprocessing http://hg.python.org/cpython/rev/d7ba4ca59023 -- nosy: +python-dev ___ Python tracker

[issue19134] test_inspect.py failed if module _multiprocessing not available

2013-09-30 Thread Remi Pointel
Remi Pointel added the comment: Yes, but it needs an import to use test.support.multiprocessing. -- ___ Python tracker ___ ___ Python-

[issue19134] test_inspect.py failed if module _multiprocessing not available

2013-09-30 Thread Brett Cannon
Brett Cannon added the comment: test.support.import_module is typically meant for global imports as function-level imports are discouraged in general. I would instead use the unittest.skipIf decorator:: @unittest.skipIf(not test.support.multiprocessing, "multiprocessing required") def te

[issue19134] test_inspect.py failed if module _multiprocessing not available

2013-09-30 Thread Remi Pointel
New submission from Remi Pointel: When I run the regress tests on OpenBSD 5.4-current, the test test_inspect.py failed because the module _multiprocessing is not available, instead of skipping the test: FAILED (errors=1) Traceback (most recent call last): File "./Lib/test/test_inspect.py", l