[issue19049] itertools.tee uses int for indices

2013-09-20 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue19049] itertools.tee uses int for indices

2013-09-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset 900bf633b7f4 by Antoine Pitrou in branch 'default': Add a comment making it explicit that itertools.tee() is already 64bit-safe (issue #19049) http://hg.python.org/cpython/rev/900bf633b7f4 -- nosy: +python-dev _

[issue19049] itertools.tee uses int for indices

2013-09-20 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue19049] itertools.tee uses int for indices

2013-09-20 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I suggest just add (yet one) explicit comment. > > int index; /* 0 <= index <= LINKCELLS */ Ok, I think a comment is good enough here. -- ___ Python tracker ___

[issue19049] itertools.tee uses int for indices

2013-09-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There are disadvantages in the changing int to Py_ssize_t. Converting Py_ssize_t to/from Python int is a little harder than converting C int or long. This change (as any other change) has a risk of introduce new bugs (as you can see on example of your patch

[issue19049] itertools.tee uses int for indices

2013-09-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ah, my bad, it seems I misunderstood the tee() implementation. So apparenly even index cannot get past 57. It's more of a consistency patch then, and I agree it isn't very important. -- priority: normal -> low stage: needs patch -> patch review title: