[issue18996] unittest: more helpful truncating long strings

Chris Withers added the comment: Okay, opened [issue21820]. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18996] unittest: more helpful truncating long strings

Ned Deily added the comment: Chris, I would start by opening a new issue. Comments on closed issues whose code is already released are likely to be overlooked. -- nosy: +ned.deily ___ Python tracker __

[issue18996] unittest: more helpful truncating long strings

Chris Withers added the comment: So, this appears to be the source of some degraded behaviour for me with Python 3.4 versus Python 3.3. This code, prior to 3.4: from testfixtures import Comparison as C class AClass: def __init__(self,x,y=None): self.x = x if y:

[issue18996] unittest: more helpful truncating long strings

Serhiy Storchaka added the comment: Oh, thank you Vajrasky. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18996] unittest: more helpful truncating long strings

Roundup Robot added the comment: New changeset a0c687dc0039 by Serhiy Storchaka in branch 'default': Remove commented out debugging code (remnants of issue #18996). http://hg.python.org/cpython/rev/a0c687dc0039 -- ___ Python tracker

[issue18996] unittest: more helpful truncating long strings

Vajrasky Kok added the comment: Hello, Serhiy. Do you want to remove this debug messaging? -- ___ Python tracker ___ ___ Python-bugs-l

[issue18996] unittest: more helpful truncating long strings

Vajrasky Kok added the comment: Serhiy, you still left debugging code there. Lib/unittest/test/test_case.py, line 879 and line 880. #print() #print(str(cm.exception)) -- nosy: +vajrasky ___ Python tracker

[issue18996] unittest: more helpful truncating long strings

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue18996] unittest: more helpful truncating long strings

Roundup Robot added the comment: New changeset 5bb83faa8818 by Serhiy Storchaka in branch 'default': Issue #18996: TestCase.assertEqual() now more cleverly shorten differing http://hg.python.org/cpython/rev/5bb83faa8818 -- nosy: +python-dev ___ Python

[issue18996] unittest: more helpful truncating long strings

Serhiy Storchaka added the comment: Indeed, I'll rename _common_shorten() to _common_shorten_repr() and call safe_repr() inside. As for two vs multiple args, first I wrote a variant with two args (you can see it in my first unlinked patch), but then I seen that general variant is not harder an

[issue18996] unittest: more helpful truncating long strings

Michael Foord added the comment: Awesome, thanks for this work. The only thing I'd say is that if _common_shorten is always called with two args - and safe_repr is always called on them - then why not have it take two args and call safe_repr on them? --

[issue18996] unittest: more helpful truncating long strings

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file31724/assertEqual_shorten.patch ___ Python tracker ___ ___ Python-bugs-li

[issue18996] unittest: more helpful truncating long strings

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file31712/assertEqual_shorten.patch ___ Python tracker ___ ___ Python-bugs-

[issue18996] unittest: more helpful truncating long strings

New submission from Serhiy Storchaka: Error message in assertEqual() is not vary useful when compared long strings with long common prefix. It looks as: 'For the first time in his life h [truncated]...' != 'For the first time in his life h [truncated]...' With the proposed patch it will look