[issue18904] Unnecessary test in file descriptor inheritance test

2013-09-09 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue18904] Unnecessary test in file descriptor inheritance test

2013-09-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset aea58e1cae75 by Victor Stinner in branch 'default': Issue #18904: test_os and test_socket use unittest.skipIf() to check if fcntl http://hg.python.org/cpython/rev/aea58e1cae75 -- ___ Python tracker

[issue18904] Unnecessary test in file descriptor inheritance test

2013-09-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset b7f6f6f59e91 by Victor Stinner in branch 'default': Issue #18904: test_socket: add inheritance tests using fcntl and FD_CLOEXEC http://hg.python.org/cpython/rev/b7f6f6f59e91 -- ___ Python tracker

[issue18904] Unnecessary test in file descriptor inheritance test

2013-09-08 Thread STINNER Victor
STINNER Victor added the comment: Thanks for the report and the patch. I removed the duplicate test, but I also added new tests using fcntl and FD_CLOEXEC. -- ___ Python tracker ___

[issue18904] Unnecessary test in file descriptor inheritance test

2013-09-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset b13cec63b495 by Victor Stinner in branch 'default': Issue #18904: Improve os.get/set_inheritable() tests http://hg.python.org/cpython/rev/b13cec63b495 -- nosy: +python-dev ___ Python tracker

[issue18904] Unnecessary test in file descriptor inheritance test

2013-09-07 Thread Ezio Melotti
Changes by Ezio Melotti : -- assignee: -> haypo stage: -> patch review type: -> behavior ___ Python tracker ___ ___ Python-bugs-lis

[issue18904] Unnecessary test in file descriptor inheritance test

2013-09-01 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue18904] Unnecessary test in file descriptor inheritance test

2013-09-01 Thread Vajrasky Kok
New submission from Vajrasky Kok: In Lib/test/test_os.py in class FDInheritanceTests, we have an unnecessary test, which is test_set_inheritable. What test_set_inheritable tests is already being covered by test_get_inheritable. Also, I think test_get_inheritable should be renamed to test_set_i