[issue18889] test_sax: multiple failures on Windows desktop

R. David Murray added the comment: For test_email, the fix was correct because the *test* didn't care about what line ending the source file had. I can't speak for sax. -- ___ Python tracker _

[issue18889] test_sax: multiple failures on Windows desktop

Tim Peters added the comment: Terry, yes, the installer won't change line endings. I think - we'll find out for sure next time a release is cut - LOL ;-) Agreed that Lib/email/test/data/msg_26.txt is probably obsolete. Fix it, if you like! It's helpful to get rid of obsolete cruft. ---

[issue18889] test_sax: multiple failures on Windows desktop

Changes by Tim Peters : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue18889] test_sax: multiple failures on Windows desktop

Roundup Robot added the comment: New changeset 8efcf3c823f9 by Tim Peters in branch '3.3': Fix issue 18889: test_sax: multiple failures on Windows desktop. http://hg.python.org/cpython/rev/8efcf3c823f9 New changeset 25211a8b by Tim Peters in branch 'default': Merge fix from 3.3 into default.

[issue18889] test_sax: multiple failures on Windows desktop

Terry J. Reedy added the comment: Having the files be the same on all systems seems the right solution. Changing .hgeol should do that, at least for the repository. Let's hope the Windows .msi installer leave line endings alone. I should install the a,b,c releases just to run the test suite wi

[issue18889] test_sax: multiple failures on Windows desktop

Tim Peters added the comment: test_email still passed on Windows under 3.2.5 (but test_sax failed). test_email and test_sax both fail under 3.3.2. I'll just push the change to .hgeol - minimally invasive, fixes the immediate problem, and it appears these "really are" binary files. --

[issue18889] test_sax: multiple failures on Windows desktop

Serhiy Storchaka added the comment: > Nit 2: why? The test passes as is. Currently test.xml and test.xml.out contain only ascii characters. But this can be changed in future. Actually I had added non-ascii characters to other test data and this had exposed some bugs in test suite. > When did

[issue18889] test_sax: multiple failures on Windows desktop

Antoine Pitrou added the comment: Marking the files as "binary" (really "don't touch") in .hgeol sounds reasonable to me. -- ___ Python tracker ___ _

[issue18889] test_sax: multiple failures on Windows desktop

Terry J. Reedy added the comment: Two things have happened with Python: we switched bytes from 'text or binary' to 'binary (or text)' in 3.0. We switched from svn to hg in 3.2. When did test_sax start failing? I have no idea. Until recently, there were much worse problems with the test suite o

[issue18889] test_sax: multiple failures on Windows desktop

Tim Peters added the comment: Seeing as Python 3 _does_ open these files in binary mode, I fiddled my local .hgeol to mark the test files as BIN (then deleted the test data directory and did an "hg revert" on the directory). Then test_sax passes. I don't know whether that's the proper fix,

[issue18889] test_sax: multiple failures on Windows desktop

Tim Peters added the comment: Suggest caution here. test_sax fails the same way for me too (Windows Vista), under both the released 3.3.2 and a Python built from the current hg default branch. However, these files (test.xml and test.xml.out) have not changed since the Python 2.7 line - the \

[issue18889] test_sax: multiple failures on Windows desktop

Terry J. Reedy added the comment: As I said on #12037, I would rather \r was not in the file. I do not know if it is present in the master repository or added by hg when cloning. Buildbots and developer desktops are different environments. The tests must work on both. Nit 1: right, I should h

[issue18889] test_sax: multiple failures on Windows desktop

Serhiy Storchaka added the comment: Why Lib/test/xmltestdata/test.xml.out contains '\r'? AFAIK Windows buildbots are happy with current tests. A nitpick for first proposed solution: you can append ".replace(b'\r', b'')" just to "f.read()". A nitpick for second proposed solution: encoding shou

[issue18889] test_sax: multiple failures on Windows desktop

Changes by Antoine Pitrou : -- nosy: +brian.curtin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue18889] test_sax: multiple failures on Windows desktop

Changes by Antoine Pitrou : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue18889] test_sax: multiple failures on Windows desktop

Changes by Antoine Pitrou : -- components: +Tests stage: commit review -> patch review ___ Python tracker ___ ___ Python-bugs-list mai

[issue18889] test_sax: multiple failures on Windows desktop

Terry J. Reedy added the comment: On #12037, David suggests instead the equivalent of this: with open(TEST_XMLFILE_OUT) as f: xml_test_out = f.read().encode('ascii') -- ___ Python tracker _

[issue18889] test_sax: multiple failures on Windows desktop

New submission from Terry J. Reedy: These are due to \r in line endings, as with #12037. File "F:\Python\dev\py34\lib\test\test_sax.py", line 634, in test_expat_file self.assertEqual(result.getvalue(), xml_test_out) Assert fails because off many \rs in xml_text_out. Same in line 649, in t