[issue18871] Be more stringent about the test suite

Nick Coghlan added the comment: The fact I don't run the tests with - uall before committing had nothing to do with it whatsoever. Nope. Nothing at all ;) -- ___ Python tracker _

[issue18871] Be more stringent about the test suite

Antoine Pitrou added the comment: Thanks for allowing me to be lazy, Nick :-) -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue18871] Be more stringent about the test suite

Roundup Robot added the comment: New changeset a62bb0481ac9 by Antoine Pitrou in branch 'default': Issue #18871: make it more explicit that the test suite should be run before committing http://hg.python.org/devguide/rev/a62bb0481ac9 -- nosy: +python-dev ___

[issue18871] Be more stringent about the test suite

Nick Coghlan added the comment: Looks good to me. I think it's OK to leave the optional resources in the set of things covered by the buildbots rather than expecting them to always be run in pre-commit testing. -- ___ Python tracker

[issue18871] Be more stringent about the test suite

Antoine Pitrou added the comment: I don't know. I wouldn't insist too much on -uall, because generally it won't find anything more (except for network tests, perhaps). -- ___ Python tracker ___

[issue18871] Be more stringent about the test suite

R. David Murray added the comment: Looks OK to me. Do we want to also recommend more explicitly that the tests be run with -uall? -- ___ Python tracker ___

[issue18871] Be more stringent about the test suite

New submission from Antoine Pitrou: Here is a proposal to make the devguide more precise and explicit about needing to run the entire test suite before committing a change. -- assignee: docs@python components: Devguide, Documentation files: test_suite.patch keywords: patch messages: 196