[issue18805] ipaddress netmask/hostmask parsing bugs

Changes by Nick Coghlan : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue18805] ipaddress netmask/hostmask parsing bugs

Roundup Robot added the comment: New changeset 19ca11099f07 by Nick Coghlan in branch '3.3': Fix #18805 NEWS entry http://hg.python.org/cpython/rev/19ca11099f07 New changeset e0b1c937e57c by Nick Coghlan in branch 'default': Merge #18805 NEWS fix from 3.3 http://hg.python.org/cpython/rev/e0b1c93

[issue18805] ipaddress netmask/hostmask parsing bugs

Nick Coghlan added the comment: Attaching my patch for reference (although I just realised I need to tweak the NEWS entry slightly to indicate that valid prefixes that were previously rejected are now accepted). Sorry we weren't able to make use of your patch Jon, but thanks for the detailed

[issue18805] ipaddress netmask/hostmask parsing bugs

Roundup Robot added the comment: New changeset ca5ea7c24370 by Nick Coghlan in branch '3.3': Issue #18805: better netmask validation in ipaddress http://hg.python.org/cpython/rev/ca5ea7c24370 New changeset 90dfb26869a7 by Nick Coghlan in branch 'default': Merge fix for #18805 from 3.3 http://hg.

[issue18805] ipaddress netmask/hostmask parsing bugs

Nick Coghlan added the comment: OK, what I have done is translated the new *tests* from the upstream patch to the standard library tests, and then used the upstream functional patch as a guide for fixing the standard library version. I'll upload the final patch here, but I won't wait for revie

[issue18805] ipaddress netmask/hostmask parsing bugs

Nick Coghlan added the comment: Oh, that's annoying - it doesn't apply cleanly to the stdlib version, even after adjusting the filenames :P -- ___ Python tracker ___ ___

[issue18805] ipaddress netmask/hostmask parsing bugs

Nick Coghlan added the comment: I've found the patch Peter mentions above (git diff HEAD^ on ipaddress-py), and will apply it to 3.3 and default. -- assignee: -> ncoghlan ___ Python tracker __

[issue18805] ipaddress netmask/hostmask parsing bugs

Yury Selivanov added the comment: bump? -- nosy: +yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue18805] ipaddress netmask/hostmask parsing bugs

pmoody added the comment: I've got a patch from pmarks that I've applied to ipaddr and the google code version of ipaddress-py. I'll get it applied to the hg ipaddress. -- ___ Python tracker __

[issue18805] ipaddress netmask/hostmask parsing bugs

Nick Coghlan added the comment: Right, I don't see any issues with backporting these fixes. One of the reasons for the PEP 411 provisional status of the API was to ensure there were no questions about what should be backported. -- ___ Python tracker

[issue18805] ipaddress netmask/hostmask parsing bugs

Eric V. Smith added the comment: I haven't had time to review this yet, but at least several of these, if true, are definitely bugs that should be backported. "254.192.128.0" as a netmask? Descending octets as the condition? Yikes. -- nosy: +eric.smith stage: -> patch review

[issue18805] ipaddress netmask/hostmask parsing bugs

New submission from Jon Foster: Short version: Validation of netmasks and hostmasks in IPv4Network is wrong: it rejects many valid netmasks, it accepts many invalid netmasks and hostmasks, and it sometimes throws the wrong exception. Patch attached. Long version: Wrongly rejecting hostmasks