[issue18667] missing HAVE_FCHOWNAT

2013-08-12 Thread Larry Hastings
Larry Hastings added the comment: Fixed in 3.3 and trunk. Thanks for the report! -- assignee: -> larry resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> behavior ___ Python tracker

[issue18667] missing HAVE_FCHOWNAT

2013-08-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 92de1a5dc3ea by Larry Hastings in branch 'default': Issue #18667: Add missing "HAVE_FCHOWNAT" symbol to posix._have_functions. http://hg.python.org/cpython/rev/92de1a5dc3ea -- ___ Python tracker

[issue18667] missing HAVE_FCHOWNAT

2013-08-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset a89226508a04 by Larry Hastings in branch '3.3': Issue #18667: Add missing "HAVE_FCHOWNAT" symbol to posix._have_functions. http://hg.python.org/cpython/rev/a89226508a04 -- nosy: +python-dev ___ Python tra

[issue18667] missing HAVE_FCHOWNAT

2013-08-10 Thread Georg Brandl
Georg Brandl added the comment: Well, since you're a RM now you should know :D -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18667] missing HAVE_FCHOWNAT

2013-08-10 Thread Larry Hastings
Larry Hastings added the comment: Georg, I'm gonna commit this for 3.4. You want it in 3.3 as well? I claim it's 100% a bugfix. -- nosy: +georg.brandl ___ Python tracker ___ _

[issue18667] missing HAVE_FCHOWNAT

2013-08-10 Thread Larry Hastings
Larry Hastings added the comment: And here's a patch for 3.3. I should have mentioned--both these patches pass the same tests as an unmodified trunk. So I think it's just ready to go in. -- Added file: http://bugs.python.org/file31216/larry.have_fchownat.3.3.patch.1.txt _

[issue18667] missing HAVE_FCHOWNAT

2013-08-10 Thread Larry Hastings
Larry Hastings added the comment: Here's a patch for trunk. It's essentially what salinger wrote, but as a patch file so it works for "review". I poked around a little to make sure we weren't going to have another baffling situation like fchmodat. AFAICT, nope, it's fine, it's as simple as t

[issue18667] missing HAVE_FCHOWNAT

2013-08-06 Thread Larry Hastings
Larry Hastings added the comment: Yup, that's a bug. My fault too. I think it should go in to the next 3.3 as well. I worry that this may be a similar situation to fchmodat--see the comment in Lib/os.py--but for now let's be brave and add HAVE_FCHOWNAT to have_functions as salinger suggests

[issue18667] missing HAVE_FCHOWNAT

2013-08-06 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18667] missing HAVE_FCHOWNAT

2013-08-06 Thread salinger
Changes by salinger : -- nosy: +doko ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mai

[issue18667] missing HAVE_FCHOWNAT

2013-08-05 Thread Petr.Salinger
New submission from Petr.Salinger: During test on kfreebsd: test_chown_dir_fd (test.test_posix.PosixTester) ... skipped 'test needs dir_fd support in os.chown()' But all *AT syscalls are supported. It looks like posixmodule.c misses propagation of that fact. --- a/Modules/posixmodule.c +++ b/