[issue18643] add a fallback socketpair() implementation in test.support

Roundup Robot added the comment: New changeset 03d3f2664930 by Victor Stinner in branch '3.4': Issue #18643: asyncio.windows_utils now reuse socket.socketpair() on Windows if https://hg.python.org/cpython/rev/03d3f2664930 -- ___ Python tracker

[issue18643] add a fallback socketpair() implementation in test.support

Roundup Robot added the comment: New changeset 6098141155f9 by Charles-François Natali in branch 'default': Issue #18643: Add socket.socketpair() on Windows. https://hg.python.org/cpython/rev/6098141155f9 -- ___ Python tracker

[issue18643] add a fallback socketpair() implementation in test.support

STINNER Victor added the comment: > In this case, socketpair-4.diff looks good to me. You can commit your patch in Python 3.5. Hey Charles-François, can you commit your patch? I forgot that you did commited it yet, and I expected socket.socketpair() to be available on all platforms. --

[issue18643] add a fallback socketpair() implementation in test.support

STINNER Victor added the comment: 2014-07-24 10:11 GMT+02:00 Charles-François Natali : >> Please also fix socketpair() in asyncio to add the while/drop unknown >> connection (well, the function in socket.py and windows_utils.py must >> be the same). > > That's a separate issue. Ok. >> Oh, and y

[issue18643] add a fallback socketpair() implementation in test.support

Charles-François Natali added the comment: > By the way, we should reuse socket.socketpair() in > asyncio.windows_utils. The Tulip is written for Python 3.3 and shares > exactly the same code base, so you should write > > Something like: > > if hasattr(socket, 'socketpair'): > socketpair = so

[issue18643] add a fallback socketpair() implementation in test.support

STINNER Victor added the comment: > I don't remember why I added a specific check on the proto parameter. I tested on Windows: socket.socket(proto=1) raises an OSError(WSAEPROTONOSUPPORT): """ WSAEPROTONOSUPPORT 10043: Protocol not supported. The requested protocol has not been configured int

[issue18643] add a fallback socketpair() implementation in test.support

STINNER Victor added the comment: 2014-07-24 0:21 GMT+02:00 Charles-François Natali : >> You should copy the code from asyncio.windows_utils.socketpair(). It checks >> also type and proto parameter: raise a ValueError for unsupported values >> (only SOCK_STREAM and proto=0 are supported). It al

[issue18643] add a fallback socketpair() implementation in test.support

Charles-François Natali added the comment: > You should copy the code from asyncio.windows_utils.socketpair(). It checks > also type and proto parameter: raise a ValueError for unsupported values > (only SOCK_STREAM and proto=0 are supported). It also supports IPv6. It > handles BlockingIOErro

[issue18643] add a fallback socketpair() implementation in test.support

Changes by STINNER Victor : -- versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18643] add a fallback socketpair() implementation in test.support

STINNER Victor added the comment: > Barring any objection, I'll commit the patch attached within a couple days. I have objections! You should copy the code from asyncio.windows_utils.socketpair(). It checks also type and proto parameter: raise a ValueError for unsupported values (only SOCK_ST

[issue18643] add a fallback socketpair() implementation in test.support

Charles-François Natali added the comment: Barring any objection, I'll commit the patch attached within a couple days. -- title: implement socketpair() on Windows -> add a fallback socketpair() implementation in test.support Added file: http://bugs.python.org/file36050/socketpair-3.diff